Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-fs/genfstab: bump to 28, EAPI 8 #28339

Closed
wants to merge 1 commit into from
Closed

sys-fs/genfstab: bump to 28, EAPI 8 #28339

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2022 •
edited by ghost

Signed-off-by: Marco Scardovi mscardovi@icloud.com

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. invalid email One or more of the maintainers don't have corresponding Bugzilla accounts. labels Nov 19, 2022
@ghost ghost changed the title sys-fs/genfstab: bump to 28, EAPI 8 sys-fs/genfstab: bump to 28, EAPI 8 [please reassign] Nov 19, 2022
@gentoo-bot gentoo-bot changed the title sys-fs/genfstab: bump to 28, EAPI 8 [please reassign] sys-fs/genfstab: bump to 28, EAPI 8 Nov 19, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: sys-fs/genfstab

sys-fs/genfstab: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. invalid email One or more of the maintainers don't have corresponding Bugzilla accounts. labels Nov 19, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-19 14:48 UTC
Newest commit scanned: 5a130c2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/82b9e40d99/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-19 15:08 UTC
Newest commit scanned: 46242eb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/58fc837412/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-24 18:58 UTC
Newest commit scanned: 1c0759e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cabc90acec/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-24 19:08 UTC
Newest commit scanned: 454e701
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e7453d19f8/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-27 13:54 UTC
Newest commit scanned: e60a4b6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6074722cda/output.html

@mattst88
Copy link
Contributor

Your second commit undoes the changes to metadata.xml from your first commit.

@mattst88
Copy link
Contributor

The commit that dropped you as a maintainer did this:

-       <maintainer type="person" proxied="yes">
-               <email>marco@scardovi.com</email>
-               <name>Marco Scardovi</name>
-       </maintainer>
-       <maintainer type="person" proxied="proxy">
-               <email>mattst88@gentoo.org</email>
-               <name>Matt Turner</name>
-       </maintainer>
+       <!-- maintainer-needed -->

so we should add me as a maintainer rather than proxy-maint.

@ghost
Copy link
Author

ghost commented Nov 29, 2022

Your second commit undoes the changes to metadata.xml from your first commit.

I'm gonna fix it ASAP

@ghost
Copy link
Author

ghost commented Nov 29, 2022

The commit that dropped you as a maintainer did this:

-       <maintainer type="person" proxied="yes">

-               <email>marco@scardovi.com</email>

-               <name>Marco Scardovi</name>

-       </maintainer>

-       <maintainer type="person" proxied="proxy">

-               <email>mattst88@gentoo.org</email>

-               <name>Matt Turner</name>

-       </maintainer>

+       <!-- maintainer-needed -->

so we should add me as a maintainer rather than proxy-maint.

Do you prefer to be only you the maintainer or readd this as is?

@mattst88
Copy link
Contributor

Readding as-is is fine with me if you plan to continue maintaining it :)

@ghost
Copy link
Author

ghost commented Nov 29, 2022

Readding as-is is fine with me if you plan to continue maintaining it :)

Yep, I am as actually I'm maintaining both upstream and downstream 😅

@scardracs
sys-fs/genfstab: add 28
61b04ec 
Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
@ghost
Copy link
Author

ghost commented Nov 29, 2022

It should be ok now

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-29 19:49 UTC
Newest commit scanned: 61b04ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/562db5c07a/output.html

@ghost ghost deleted the genfstab branch November 29, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@gentoo-bot @gentoo-repo-qa-bot @mattst88 @scardracs