Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-crypt/jacksum: min. java 11 #28346

Closed
wants to merge 1 commit into from
Closed

app-crypt/jacksum: min. java 11 #28346

wants to merge 1 commit into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Nov 20, 2022

Closes: https://bugs.gentoo.org/881197
Signed-off-by: Volkmar W. Pogatzki gentoo@pogatzki.net

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: app-crypt/jacksum

app-crypt/jacksum: @gentoo/java

Linked bugs

Bugs linked: 881197

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 20, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-20 09:08 UTC
Newest commit scanned: ab427d6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a50e8811ce/output.html

@vaukai vaukai force-pushed the jacksum branch 2 times, most recently from edfb98c to 762917c Compare November 20, 2022 09:27
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-20 09:38 UTC
Newest commit scanned: 762917c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fcadf6a734/output.html

@fordfrog
Copy link
Contributor

is there a reason why only compilation is lifted up to java 11? because if that part of the code is triggered during runtime and the class is not found, the app will crash with ClassNotFoundException.

@vaukai
app-crypt/jacksum: min. java 11
d97f952 
Closes: https://bugs.gentoo.org/881197
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai
Copy link
Contributor Author

vaukai commented Nov 30, 2022

is there a reason why only compilation is lifted up to java 11? because if that part of the code is triggered during runtime and the class is not found, the app will crash with ClassNotFoundException.

@fordfrog Thanks for the review. I simply forgot respecting runtime. Adjustment just done including rbump.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-30 08:54 UTC
Newest commit scanned: d97f952
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/92f1fe975f/output.html

@gentoo-bot gentoo-bot closed this in e854015 Dec 1, 2022
@vaukai vaukai deleted the jacksum branch December 1, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@vaukai @gentoo-bot @gentoo-repo-qa-bot @fordfrog