dev-util/electron: Fix compilation with ICU-58 (#599346) #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original patch by Brad Laue. Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=599346 Package-Manager: portage-2.3.0
SoapGentoo
approved these changes
Nov 15, 2016
There was a problem hiding this comment.
@elprans In general, there's no need to rename patches, if you just use ${PN} + hardcoded version number.
@SoapGentoo In general, yes, but electron's patches are highly version-sensitive. This simple rename is rather an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original patch by Brad Laue.
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=599346
Package-Manager: portage-2.3.0