www-client/chromium: add missing licenses, drop unrar dependency #28465
Conversation
gentoo-bot
added
assigned
ghost
changed the title
ghost
changed the title
ghost
changed the title
Bug: https://bugs.gentoo.org/492424 Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @scardracs www-client/chromium: @gentoo/chromium Linked bugsBugs linked: 492424 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2022-11-28 19:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| third_party/ruy | ||
| third_party/six | ||
| third_party/ukey2 | ||
| third_party/unrar |
There was a problem hiding this comment.
Is this line still needed?
There was a problem hiding this comment.
We are looking if maintains it and "enforce" people to accept unRAR license or to make it conditional
Pull request CI reportReport generated at: 2022-11-28 19:48 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| pgo? ( https://github.com/elkablo/chromium-profiler/releases/download/v0.2/chromium-profiler-0.2.tar ) | ||
| " | ||
|
|
||
| LICENSE="BSD Apache-2.0 APSL-2 BSD-2 GPL-2 GPL-2+ GPL-3+ icu ISC LGPL-2 LGPL-2+ LGPL-2.1 LGPL-2.1+ MIT MPL-1.1 MPL-2.0 Ms-PL public-domain" |
There was a problem hiding this comment.
ICU is conditional with USE=-system-icu
There was a problem hiding this comment.
That's actually a tracking. As soon as I have more info I'll update it or drop this PR in favour of a dev one
|
Honestly I don't merge this with removing unrar code, because you open a security risk for users without notice. |
Then the other option is to make package masked by default and add LICENSE="unrar". This would also upset people. Perhaps patch should be conditional on USE flag? Or alternatively add a news item. |
ghost
marked this pull request as draft
|
Closing as floppym is overtaking it. |
ghost
closed this
For tracking. If any dev wants to overtake it feel free to do so.
Bug https://bugs.gentoo.org/492424
Signed-off-by: Marco Scardovi mscardovi@icloud.com