net-misc/icaclient: bump to 22.12.0.12 #28493
Conversation
Here we do not just bump the version but also change the way we deal with the shared config file between this ebuild and its plugin media-plugins/hdx-realtime-media-engine. Also we move the rdep to sys-libs/llvm-libunwind to the plugin. And if the user wants hdx support on icaclient they have to set a USE flag. The plugin will not work if icaclient is not built with support for it and the plugin itself contains the tool to enable itself so we turn the dep chain around, the plugin is even a bdep of the application. Closes: https://bugs.gentoo.org/883775 Closes: https://bugs.gentoo.org/881637 Signed-off-by: Henning Schild <henning@hennsch.de>
Pull Request assignmentSubmitter: @henning-schild media-plugins/hdx-realtime-media-engine: @henning-schild, @gentoo/proxy-maint Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-12-01 15:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@juippis this is open for a while now, not a simple bump but i would like to ask you to review, you have been involved in other PRs on that package |
| xdg_mimeinfo_database_update | ||
|
|
||
| if ! use hdx; then | ||
| if [ -x "${ROOT}${ICAROOT}"/rtme/RTMEconfig ]; then |
| default | ||
| rm lib/UIDialogLibWebKit.so || die | ||
|
|
||
| cp nls/en/module.ini . |
There was a problem hiding this comment.
missing die on cp, rtmeconfig call, mv and mv.
|
Sorry I was away with a travel laptop that isn't suited for building these PR packages, and put my full focus on going through my unread bugzilla mail. Glad to see @thesamesam was able to process this! |
Here we do not just bump the version but also change the way we deal with the shared config file between this ebuild and its plugin media-plugins/hdx-realtime-media-engine.
Also we move the rdep to sys-libs/llvm-libunwind to the plugin. And if the user wants hdx support on icaclient they have to set a USE flag. The plugin will not work if icaclient is not built with support for it and the plugin itself contains the tool to enable itself so we turn the dep chain around, the plugin is even a bdep of the application.
Closes: https://bugs.gentoo.org/883775
Closes: https://bugs.gentoo.org/881637
Signed-off-by: Henning Schild henning@hennsch.de