Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-vpn/vtun: Fix shell script compatibility issue in rc script (bashism). #28682

Closed

Conversation

leakingmemory
Copy link
Contributor

Newline into the separator (IFS) apparently isn't very easy to accomplish. This seems to be the best way of doing that without relying on bash features.

I guess this fixes the last remaining reported bug for net-vpn/vtun at the moment, so hopefully the scheduled removal can be averted?

#849446

Bug: https://bugs.gentoo.org/849446
Signed-off-by: Jan-Espen Oversand <sigsegv@radiotube.org>
@leakingmemory leakingmemory changed the title Fix shell script compatibility issue in rc script (bashism). net-vpn/vtun: Fix shell script compatibility issue in rc script (bashism). Dec 16, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @leakingmemory
Areas affected: ebuilds
Packages affected: net-vpn/vtun

net-vpn/vtun: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 849446


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 16, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-16 20:43 UTC
Newest commit scanned: 67316b0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/391b646484/output.html

@thesamesam
Copy link
Member

Nice work, thanks! I'll unmask it.

@thesamesam
Copy link
Member

Would you like to adopt it?

@leakingmemory
Copy link
Contributor Author

Hi,

Yes, sure, I think this is something I can take on. I'm quite new to writing ebuilds and Gentoo procedures so I'll appreciate greatly some guidance, and obviously thanks to all of you who have done so already. :)

(Btw. sorry if the message got duplicated. It appears replying by email didn't work properly)

@thesamesam
Copy link
Member

Sounds great! I normally may not encourage someone to do it so early but I think given:

  1. vtun was at risk of removal;
  2. you managed to fix all the bugs properly
    it's no problem.

See https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml for how to do it (new PR). Come ask on IRC in #gentoo-proxy-maint or #gentoo-dev-help if get stuck.

@leakingmemory
Copy link
Contributor Author

Added https://bugs.gentoo.org/886595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
4 participants