New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-office/gnucash: revbump, add unconditional gtest dep, fix bug 884755, update deps minimum #28712
Conversation
Pull request CI reportReport generated at: 2022-12-19 19:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull Request assignmentSubmitter: @scardracs app-office/gnucash: @titanofold Linked bugsBugs linked: 884755 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-12-19 22:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This is OK in theory but a bit dubious. Do we know why it's needed unconditionally? It should be a simple patch (normally) to the upstream build system to fix it to be conditional. |
Pull request CI reportReport generated at: 2022-12-21 12:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-21 21:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-21 22:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-21 22:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-21 23:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
As we said on IRC we could consider it fixed for now. If you and @titanofold don't have any other point could you please merge it? |
For e744502, please make the commit message's first line/title/summary descriptive of what you're actually fixing ("add unconditional gtest dep"). |
Gnucash team adds gtest as unconditional dep. We are gonna respect this requirement, adding it too. See: https://bugs.gnucash.org/show_bug.cgi?id=795250 Closes: https://bugs.gentoo.org/884755 Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Pull request CI reportReport generated at: 2022-12-24 22:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-24 22:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Closes: #28737 Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Pull request CI reportReport generated at: 2022-12-25 10:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Thanks, I've merged this for now even though we may still want to make it optional, as we shouldn't leave it broken in the meantime. |
This has not to be merged until gtest scrict request has been sorted out
Closes: https://bugs.gentoo.org/884755
Closes: #28737
Signed-off-by: Marco Scardovi mscardovi@icloud.com