Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-office/gnucash: revbump, add unconditional gtest dep, fix bug 884755, update deps minimum #28712

Closed
wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2022

This has not to be merged until gtest scrict request has been sorted out

Closes: https://bugs.gentoo.org/884755
Closes: #28737

Signed-off-by: Marco Scardovi mscardovi@icloud.com

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 19, 2022
@ghost ghost changed the title app-office/gnucash, app-doc/gnucash-docs: add 4.13, drop 4.12 app-office/gnucash, app-doc/gnucash-docs: add 4.13, drop 4.12 [please reassign] Dec 19, 2022
@gentoo-bot gentoo-bot changed the title app-office/gnucash, app-doc/gnucash-docs: add 4.13, drop 4.12 [please reassign] app-office/gnucash, app-doc/gnucash-docs: add 4.13, drop 4.12 Dec 19, 2022
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 19, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-19 19:33 UTC
Newest commit scanned: 14eb1d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f64c468f36/output.html

@ghost ghost marked this pull request as draft December 19, 2022 19:42
@ghost ghost changed the title app-office/gnucash, app-doc/gnucash-docs: add 4.13, drop 4.12 app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional Dec 19, 2022
@ghost ghost changed the title app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional [please reassign] Dec 19, 2022
@gentoo-bot gentoo-bot changed the title app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional [please reassign] app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional Dec 19, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: app-office/gnucash

app-office/gnucash: @titanofold

Linked bugs

Bugs linked: 884755


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 19, 2022
@ghost ghost marked this pull request as ready for review December 19, 2022 22:37
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-19 22:43 UTC
Newest commit scanned: a2800e5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3eae5e5a12/output.html

@thesamesam
Copy link
Member

thesamesam commented Dec 20, 2022

This is OK in theory but a bit dubious. Do we know why it's needed unconditionally? It should be a simple patch (normally) to the upstream build system to fix it to be conditional.

@ghost ghost marked this pull request as draft December 21, 2022 11:57
@ghost ghost changed the title app-office/gnucash, app-doc/gnucash-docs: make gtest unconditional app-office/gnucash: revbump, fix bug 884755 Dec 21, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-21 12:08 UTC
Newest commit scanned: 3dcc1d8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f0822eb831/output.html

@ghost ghost marked this pull request as ready for review December 21, 2022 21:43
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-21 21:53 UTC
Newest commit scanned: 9595f2b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6b14bcc35f/output.html

@ghost ghost changed the title app-office/gnucash: revbump, fix bug 884755 app-office/gnucash: revbump, fix bug 884755, update deps minimum, add myself as co-maintainer Dec 21, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-21 22:13 UTC
Newest commit scanned: a101b80
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/211ec3ca58/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-21 22:33 UTC
Newest commit scanned: fdbb322
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f741c5f532/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-21 23:33 UTC
Newest commit scanned: 93edf5e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1b11e11a1a/output.html

@ghost
Copy link
Author

ghost commented Dec 22, 2022

This is OK in theory but a bit dubious. Do we know why it's needed unconditionally? It should be a simple patch (normally) to the upstream build system to fix it to be conditional.

As we said on IRC we could consider it fixed for now. If you and @titanofold don't have any other point could you please merge it?

@thesamesam
Copy link
Member

For e744502, please make the commit message's first line/title/summary descriptive of what you're actually fixing ("add unconditional gtest dep").

@ghost ghost changed the title app-office/gnucash: revbump, fix bug 884755, update deps minimum, add myself as co-maintainer app-office/gnucash: revbump, add unconditional gtest dep, fix bug 884755, update deps minimum, add myself as co-maintainer Dec 24, 2022
Gnucash team adds gtest as unconditional dep.
We are gonna respect this requirement, adding it too.

See: https://bugs.gnucash.org/show_bug.cgi?id=795250
Closes: https://bugs.gentoo.org/884755

Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-24 22:13 UTC
Newest commit scanned: d28f610
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/00079db008/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-24 22:23 UTC
Newest commit scanned: e033193
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9115a80f48/output.html

Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
Closes: #28737

Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
@ghost ghost changed the title app-office/gnucash: revbump, add unconditional gtest dep, fix bug 884755, update deps minimum, add myself as co-maintainer app-office/gnucash: revbump, add unconditional gtest dep, fix bug 884755, update deps minimum Dec 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-25 10:03 UTC
Newest commit scanned: fcdb03c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cf55cb6d02/output.html

@thesamesam
Copy link
Member

Thanks, I've merged this for now even though we may still want to make it optional, as we shouldn't leave it broken in the meantime.

@ghost ghost deleted the gnucash branch January 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants