Audacity 3.2.3 #28715
Audacity 3.2.3 #28715
Conversation
Pull Request assignmentSubmitter: @ArsenArsen app-eselect/eselect-wxwidgets: @gentoo/wxwidgets Linked bugsBugs linked: 822978, 777366, 873124, 577030 Missing Bugzilla accountsWARNING: The following maintainers do not match any Bugzilla accounts: Please either fix the e-mail addresses in metadata.xml or create a Bugzilla account, and request reassignment afterwards. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
juippis
added
the
do not merge
Pull request CI reportReport generated at: 2022-12-19 19:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
e63a7ce
to
d315b69
Compare
Pull request CI reportReport generated at: 2022-12-20 10:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
d315b69
to
fe71fae
Compare
Pull request CI reportReport generated at: 2022-12-20 20:48 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
app-eselect/eselect-wxwidgets/eselect-wxwidgets-20180529-r1.ebuild
Outdated
Show resolved
Hide resolved
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
fe71fae
to
f4e07bd
Compare
Pull request CI reportReport generated at: 2022-12-21 20:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
f4e07bd
to
2ddabcf
Compare
Pull request CI reportReport generated at: 2022-12-22 18:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Hmm, reading the logs a bit more carefully, I get:
|
|
oh, I forgot to remove those (they were originally in the telemetry patch and |
|
hmm, cmake seems to be lying about the latter actually, it was JACK that I removed (and indeed, that is a comment for that reason) weird... maybe this is another of cmakes oddities |
|
ah, I think this file is not getting sourced under some USE configuration, because with all USEs on, and with none, I don't see it |
|
similarly for has_threadpool in the non telemetry case, it goes "unused" (it's referenced directly in the code, the path just doesn't get descended down), but it is actually used. I'm not sure if this is suppressible |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
2 times, most recently
from
201d490
to
661e5bc
Compare
Pull request CI reportReport generated at: 2022-12-27 20:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
2 times, most recently
from
3d3b5f6
to
f872e7c
Compare
|
Hacks begone! We should have eselect-wxwidgets-20230114 now. |
Pull request CI reportReport generated at: 2023-01-14 21:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-01-14 22:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
f872e7c
to
e0a812c
Compare
|
|
||
| DESCRIPTION="Eselect module and wrappers for wxWidgets" | ||
| HOMEPAGE="https://gitweb.gentoo.org/proj/eselect-wxwidgets.git/" | ||
| SRC_URI="https://dev.gentoo.org/~sam/distfiles/app-eselect/eselect-wxwidgets/eselect-wxwidgets-20230114.tar.xz" |
There was a problem hiding this comment.
| SRC_URI="https://dev.gentoo.org/~sam/distfiles/app-eselect/eselect-wxwidgets/eselect-wxwidgets-20230114.tar.xz" | |
| SRC_URI="https://dev.gentoo.org/~sam/distfiles/app-eselect/eselect-wxwidgets/${P}.tar.xz" |
| --- | ||
| This effectively makes the packaged version v238. | ||
|
|
||
| Forwarded: https://codeberg.org/tenacityteam/portsmf/pulls/11 |
There was a problem hiding this comment.
I usually prefer this up the top, but it's no big deal.
There was a problem hiding this comment.
I like it here, usually, since it doesn't change the rest of the mboxy structure, but nothing inherently changes indeed
| cmake_src_prepare | ||
|
|
||
| local header_subs="${S}/lib-src/header-substitutes" | ||
| cat <<-EOF >"${header_subs}/allegro.h" || die |
There was a problem hiding this comment.
You used <<-EOF, so you could indent the bits below, but it's not needed to do so here if you don't want to.
Pull request CI reportReport generated at: 2023-01-17 13:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
e0a812c
to
42bd32e
Compare
Pull request CI reportReport generated at: 2023-01-17 14:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
42bd32e
to
a651ede
Compare
|
Audacity got a release in the meanwhile. Updated! |
Pull request CI reportReport generated at: 2023-01-18 09:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
a651ede
to
14a8bd6
Compare
Pull request CI reportReport generated at: 2023-01-18 10:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
14a8bd6
to
620689c
Compare
Pull request CI reportReport generated at: 2023-01-20 21:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/577030#c37 Signed-off-by: brahmajit das <listout@protonmail.com> Closes: gentoo#28360 Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
Closes: https://bugs.gentoo.org/577030 Closes: https://bugs.gentoo.org/873124 Signed-off-by: brahmajit das <listout@protonmail.com> Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
This permits build systems to rely on the exit code of wx-config.
As an example:
$ /usr/lib64/wx/config/gtk3-unicode-3.0-gtk3 \
--flavour=release 2>/dev/null 1>&2|| echo foo
foo
$ wx-config --flavour=release 2>/dev/null 1>&2|| echo foo
$
This is the first version of eselect-wxwidgets which includes the shim
files in version control.
Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
This update also links against system portaudio. Keywords dropped to ~amd64 due to media-libs/portsmf. Closes: https://bugs.gentoo.org/777366 Closes: https://bugs.gentoo.org/822978 Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
ArsenArsen
force-pushed
the
audacity-3.2.2
branch
from
620689c
to
e6c849f
Compare
Pull request CI reportReport generated at: 2023-01-20 21:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
To reviewers: please do not merge, but feedback is, of course, encouraged.
Afternoon,
This PR includes a modified version of the wxGTK patch by @listout (thanks!)
with a few autodeps discovered by qa-vdb fixed, and a passing (non-GUI)
testsuite. As suggested in the original bump PR (#28360) this version retains
the autotools(ish) build system.
Note that the PR includes a horrid hack in the eselect-wxwidgets commit. I've
sent a patch to the wxwidgets project address with a more proper solution
(placing a few execs in). This is required by FindwxWidgets.cmake in the
Audacity tree.
The wxGTK ebuild specifies a USEDEP on both pcre{16,32}. This is because the
chosen library depends on architecture (namely, wchar_t size). The alternative
that I see immediately is --enable-utf8, but flipping this flag causes ABI to
break according to abidiff (I didn't give it too close of an inspection, but I
can definitely see that being the case, since it changes how wxWidgets
represents strings). I'd like to hear whether @leio has any alternatives or
thougts on that topic too.
Notably, maybe libpcre2[unicode] should also be depended on, since AFAICT it's
assumed that the linked pcre2 works on Unicode wchars. I also decided to drop
the subslot operator on this dependency since, according to the libpcre2
metadata, the subslot represents the ABI version of -posix.
I lack the experience required to be sure in my review of the wxGTK PR, but my
"generic steps" for checking find the current revision probably okay - with the
caveat that I haven't gone over the full configure.in yet (but I can before
this is merged, but I'd like to get a "first pass" out so that I can dedicate a
little bit of time back to some other projects).
Now, onto the star of the show. The Audacity ebuild allows telemetry in
Audacity to be re-enabled. I'm unconvinced this is useful, as I needed to rip
keys out of prebuilts to actually provide them, it's off by default, the
breakpad support is disabled since that fails to build, and would likely be
useless (since it requires that the receiving side of the crash reports has
debug info). Playing around in it a bit with -telemetry, I only see one
non-UNIX %socket syscall, namely a bind to localhost; though I'm sure my random
button clicking has low coverage - I haven't a clue what these buttons do.
Unless there's secret codes in the ASCII art and music notation embedded in the
main executable and lib-... modules, or hard-coded IPs, I doubt there's
anything that actually sends requests. The other networking-related feature,
Audio.com sharing, can be enabled independently (and I tested for %socket calls
with it enabled). That appeared to work in a brief test, though I don't use
the service.
Both of these features are omitted in all the distros I've looked for
information (Fedora, Alpine, Debian). While some users might find Audio.com
uploading useful, I'm unconvinced there's use in retaining the telemetry flag,
and worse, it could bring us at odds with upstream, which possibly doesn't
expect this. This is why all three "secrets" have been replaced with
placeholders in the current commit. I included it for posterity but my vote is
towards removing it.
I am yet to set up netns' for sniff testing the traffic Audacity generates in
either configuration, for the same reason as not properly reading configure.in
above.
In addition, this ebuild builds Audacity against Tenacity's fork of PortSMF,
and addresses the non-system portaudio issue raised a while ago. PortSMF
itself has some odd stuff upstream, the patches there have been submitted, and
require more testing on Windows.
Besides the few question marks above, this appears to work well.
Thanks in advance, have a great day.
Cc: @juippis, @thesamesam