media-sound/clementine: fix deps and link #28722
Conversation
Pull Request assignmentSubmitter: @DarthGandalf media-sound/clementine: @DarthGandalf, @gentoo/proxy-maint, @gentoo/sound Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-12-21 01:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-12-25 00:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
The commit message contains only Bug: tags, no Closes:. Are the bugs not fixed by this PR?
qa-vdb finds a possibly missing RDEPEND media-libs/alsa-lib
and media-libs/libmtp -> media-libs/libmtp:=
I would put S below SRC_URI, not above
Also BDEPEND last, not first (but that's just a matter of style)
| @@ -116,9 +119,6 @@ src_configure() { | |||
| # spotify is not in portage | |||
There was a problem hiding this comment.
The spotify part is missing from the live ebuild. Is that intended?
There was a problem hiding this comment.
That's correct. In the release we disable it, but in live ebuild there's nothing to disable, because it's removed upstream.
This PR adds fixed ebuilds, but doesn't remove broken ones. Somehow I prefer closing the bug when it's finally fixed, but I can change the tag if you prefer it that way.
It looks like you use USE=-alsa, but alsa-lib is installed on your system, so got automagically found... Fixed.
good catch
alright |
It's ok as long as you keep track of them :)
Yes, I built it with USE='-*' to see what it does, but I forgot to mention this. Thanks |
DarthGandalf
force-pushed
the
clem
branch
2 times, most recently
from
059ca99
to
69595d7
Compare
Pull request CI reportReport generated at: 2023-01-02 11:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-01-02 11:14 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
With USE="alsa cdda dbus ipod lastfm mtp pulseaudio test udisks -box -debug -dropbox -googledrive -mms -moodbar -projectm -seafile -skydrive -wiimote", qa-vdb reports it needs media-libs/libpulse in RDEPEND. Now it is in DEPEND only.
$ lddtree `which clementine`
clementine => /usr/bin/clementine (interpreter => /lib64/ld-linux-x86-64.so.2)
...
libpulse.so.0 => /usr/lib64/libpulse.so.0
...
libasound.so.2 => /usr/lib64/libasound.so.2
crypto++ was required only for spotify which is gone (https://bugs.gentoo.org/885529) Closes: https://bugs.gentoo.org/887105 Closes: https://bugs.gentoo.org/887163 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
|
Actually it was media-sound/pulseaudio instead. Done. |
Pull request CI reportReport generated at: 2023-01-02 12:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I had to update the copyright year to 2023, I hope you don't mind. Thanks again |
crypto++ was required only for spotify which is gone (https://bugs.gentoo.org/885529)
Bug: https://bugs.gentoo.org/887105
Bug: https://bugs.gentoo.org/887163
Signed-off-by: Alexey Sokolov alexey+gentoo@asokolov.org