Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-libs/assimp: disable failing tests #28796

Closed
wants to merge 1 commit into from
Closed

media-libs/assimp: disable failing tests #28796

wants to merge 1 commit into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Dec 25, 2022

Closes: https://bugs.gentoo.org/879147
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

@waebbl
media-libs/assimp: disable failing tests
44eccb9 
Closes: https://bugs.gentoo.org/879147
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: media-libs/assimp

media-libs/assimp: @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 879147

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-25 09:23 UTC
Newest commit scanned: 44eccb9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/563deb538e/output.html

ceamac
ceamac approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@ceamac ceamac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this upstream issue, it's the reason tests fail (they even have an Equal method that accepts an epsilon but don't use it in tests). Please follow it and remove the patches when (or if) the tests get fixed upstream.

Thank you!

@waebbl
Copy link
Contributor Author

waebbl commented Jan 9, 2023

Thanks for the hint. Haven't seen the issue so far. I subscribed and will update the package accordingly.

@gentoo-bot gentoo-bot closed this in eac45bb Jan 9, 2023
@waebbl waebbl deleted the assimp-tests-879147 branch January 9, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceamac ceamac ceamac approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@waebbl @gentoo-bot @gentoo-repo-qa-bot @ceamac