Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/pefile: remove dependency to dev-python/future #28825

Closed
wants to merge 1 commit into from
Closed

dev-python/pefile: remove dependency to dev-python/future #28825

wants to merge 1 commit into from

Conversation

hamarituc
Copy link
Contributor

@hamarituc
dev-python/pefile: remove dependency to dev-python/future
912c399 
Closes: https://bugs.gentoo.org/888279
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hamarituc
Areas affected: ebuilds
Packages affected: dev-python/pefile

dev-python/pefile: @hamarituc, @thesamesam

Linked bugs

Bugs linked: 888279

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 26, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-26 12:08 UTC
Newest commit scanned: 912c399
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/becbc047c6/output.html

mgorny
mgorny reviewed Dec 26, 2022
View reviewed changes
dev-python/pefile/pefile-2022.5.30-r1.ebuild
SLOT="0"

PATCHES=(
"${FILESDIR}/${P}-remove-future.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fetch it from GitHub (append .patch to the commit URL) or is that not clean to apply? The patch is a big large-ish.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clean to apply. I modified the patch. There is a change in the tests-directory which is not shipped in the release tarball.

@hamarituc hamarituc deleted the dev-python/pefile branch December 27, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@hamarituc @gentoo-bot @gentoo-repo-qa-bot @mgorny