Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 #28870

Closed
wants to merge 2 commits into from
Closed

sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 #28870

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2022 •
edited by ghost

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 28, 2022
@ghost ghost changed the title sys-auth/libfprint: call python (fix #888683) sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 Dec 28, 2022
@ghost ghost changed the title sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 [please reassign] Dec 28, 2022
@gentoo-bot gentoo-bot changed the title sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 [please reassign] sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 Dec 28, 2022
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 28, 2022
@ghost
Copy link
Author

ghost commented Dec 28, 2022

@thesamesam when you have some spare time let me know if it LGTY

@ghost ghost changed the title sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 [please reassign] Dec 28, 2022
@gentoo-bot gentoo-bot changed the title sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 [please reassign] sys-auth/libfprint: call python (fix #888683) - sys-auth/fprintd: add pam_wrapper unconditionally during test, re-fix #764500 Dec 28, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: sys-auth/fprintd, sys-auth/libfprint

sys-auth/fprintd: @gentoo/proxy-maint (maintainer needed)
sys-auth/libfprint: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 850316, 888683, 764500

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 28, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-28 11:23 UTC
Newest commit scanned: 43d5a63
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b14772ab6a/output.html

juippis
juippis reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just can't get this to compile. Did it work for you?

@ghost ghost marked this pull request as draft January 12, 2023 14:13
@scardracs
sys-auth/libfprint: call python (fix #888683)
01ad084 
Closes: https://bugs.gentoo.org/888683
Closes: https://bugs.gentoo.org/850316

Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-12 14:53 UTC
Newest commit scanned: 9c171d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c27a1a621e/output.html

@scardracs
sys-auth/fprintd: fix missing pypamtest during test #764500
067fc49 
Bug was already closed for a previous version of fprintd, but it comes back
on latest version. I'm gonna fix it once and for all

Bug: https://bugs.gentoo.org/764500

Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-12 15:13 UTC
Newest commit scanned: 067fc49
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/366ab9b82a/output.html

@ghost
Copy link
Author

ghost commented Jan 18, 2023

@juippis this is the only PR I'm gonna drop because I have no way to test it in short time. If someone wants to take it up feel free to do so.

@ghost ghost closed this Jan 18, 2023
@ghost ghost deleted the fprint branch January 18, 2023 20:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@gentoo-bot @gentoo-repo-qa-bot @juippis @scardracs