Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-cluster/lmod: Add symlinks to profile #28872

Closed
wants to merge 2 commits into from
Closed

sys-cluster/lmod: Add symlinks to profile #28872

wants to merge 2 commits into from

Conversation

APN-Pucky
Copy link
Contributor

@APN-Pucky APN-Pucky commented Dec 28, 2022 •
edited

Signed-off-by: Alexander Puck Neuwirth alexander@neuwirth-informatik.de

I had to setup those symlinks for lmod to work.
Do you prefer copy/installing these files so that etc-update can handle updated profiles?

If you disagree with including this step in the ebuild I'll change the PR to adding a post_install message.

Cheers,
APN

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @APN-Pucky
Areas affected: ebuilds
Packages affected: sys-cluster/lmod

sys-cluster/lmod: @gentoo/sci

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 28, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-28 13:28 UTC
Newest commit scanned: 6a7d619
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/867da7f948/output.html

@APN-Pucky
Copy link
Contributor Author

The similar modules package also uses symlinks: https://github.com/gentoo/sci/blob/master/sys-cluster/modules/modules-4.6.0.ebuild

@APN-Pucky
sys-cluster/lmod: Add symlinks to profile
6b3183a 
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-01 18:38 UTC
Newest commit scanned: 6b3183a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1d21792867/output.html

AndrewAmmerlaan
AndrewAmmerlaan reviewed Jan 29, 2023
View reviewed changes
Copy link
Member

@AndrewAmmerlaan AndrewAmmerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do something similar for the completion files?

/usr/share/Lmod/init/fish_tab_completion/module.fish
/usr/share/Lmod/init/lmod_bash_completions

sys-cluster/lmod/lmod-8.6.14-r1.ebuild Outdated Show resolved Hide resolved
@APN-Pucky @AndrewAmmerlaan
Update sys-cluster/lmod/lmod-8.6.14-r1.ebuild
051976d 
Co-authored-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Alexander Puck Neuwirth <APN-Pucky@users.noreply.github.com>
@APN-Pucky
Copy link
Contributor Author

APN-Pucky commented Jan 29, 2023 •
edited

Do we need to do something similar for the completion files?

/usr/share/Lmod/init/fish_tab_completion/module.fish
/usr/share/Lmod/init/lmod_bash_completions

I don't use/have fish, but in a normal bash I don't need lmod_bash_completions for completion (eg. ml <TABs>) since the call order of files seems to be profile->bash->lmod_bash_completions .

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-29 14:14 UTC
Newest commit scanned: 051976d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c204161125/output.html

@AndrewAmmerlaan
Copy link
Member

Thanks 👍

freijon pushed a commit to freijon/gentoo that referenced this pull request Jan 31, 2023
@APN-Pucky @freijon
sys-cluster/lmod: Add symlinks to profile
975ba05 
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Closes: gentoo#28872
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAmmerlaan AndrewAmmerlaan AndrewAmmerlaan left review comments

@SoapGentoo SoapGentoo Awaiting requested review from SoapGentoo

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@APN-Pucky @gentoo-bot @gentoo-repo-qa-bot @AndrewAmmerlaan