New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/liquvi & libquvi-scripts: allow use of luajit and lua version 5.4 for build #28894
Conversation
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
See bug #504876: libquvi used to build only with lua version 5.1 - the configure.ac file is to be patched in order to be able to build with luajit - the second patch allow build with lua version 5.4 Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Pull Request assignmentSubmitter: @Jocelyn-MAYER media-libs/libquvi: @gentoo/video Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-12-29 18:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Thanks! This looks good. I've made a few changes on merging:
I've also dropped the merge commits -- see https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Configuration. Nice work! |
commit 385b637 (HEAD -> master, origin/master, origin/HEAD)
commit 2b50219
|
Sorry, I'm a newbie with github and I did all using the web interface, not command line at home. |
Current revision of libquvi & libquvi-scripts only build with lua version 5.1
In order to avoid keeping old lua version installed, those patches allow to build using luajit and lua 5.4
Luajit support requires only a small patch in libquvi configure.ac file to make it checked
Lua version 5.4 requires patching the lua handlers definition and registration.
Bumped r100 to r101 in order to apply those patches.
Reported-By: Jocelyn Mayer l_indien@mailmagic.fr
Tested-By: Jocelyn Mayer l_indien@mailmagic.fr
Bug: https://bugs.gentoo.org/504876
Signed-off-by: Jocelyn Mayer l_indien@mailmagic.fr