Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/liquvi & libquvi-scripts: allow use of luajit and lua version 5.4 for build #28894

Closed
wants to merge 7 commits into from

Conversation

Jocelyn-MAYER
Copy link
Contributor

@Jocelyn-MAYER Jocelyn-MAYER commented Dec 29, 2022

Current revision of libquvi & libquvi-scripts only build with lua version 5.1
In order to avoid keeping old lua version installed, those patches allow to build using luajit and lua 5.4
Luajit support requires only a small patch in libquvi configure.ac file to make it checked
Lua version 5.4 requires patching the lua handlers definition and registration.
Bumped r100 to r101 in order to apply those patches.

Reported-By: Jocelyn Mayer l_indien@mailmagic.fr
Tested-By: Jocelyn Mayer l_indien@mailmagic.fr
Bug: https://bugs.gentoo.org/504876
Signed-off-by: Jocelyn Mayer l_indien@mailmagic.fr

Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
See bug #504876:
libquvi used to build only with lua version 5.1
- the configure.ac file is to be patched in order to be able to build with luajit
- the second patch allow build with lua version 5.4

Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Jocelyn-MAYER
Areas affected: ebuilds
Packages affected: media-libs/libquvi, media-libs/libquvi-scripts

media-libs/libquvi: @gentoo/video
media-libs/libquvi-scripts: @gentoo/video

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 29, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-29 18:13 UTC
Newest commit scanned: de67adb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a84c8b21d8/output.html

@thesamesam
Copy link
Member

Thanks! This looks good.

I've made a few changes on merging:

  • Squashed commits
  • Adjusted commit messages to match "cat/pkg: summary" format
  • Added Closes: tags to the commits to tag the bugs
  • Split into one-commit-per-package

I've also dropped the merge commits -- see https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Configuration.

Nice work!

@thesamesam
Copy link
Member

commit 385b637 (HEAD -> master, origin/master, origin/HEAD)
Author: Jocelyn-MAYER l_indien@mailmagic.fr
Date: Thu Dec 29 18:43:57 2022 +0100

media-libs/libquvi-scripts: Allow build using luajit and lua version 5.4

Closes: https://bugs.gentoo.org/504876
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Sam James <sam@gentoo.org>

commit 2b50219
Author: Jocelyn-MAYER l_indien@mailmagic.fr
Date: Thu Dec 29 18:28:00 2022 +0100

media-libs/libquvi: support luajit and lua5.4

libquvi used to build only with lua version 5.1
- the configure.ac file is to be patched in order to be able to build with luajit
- the second patch allow build with lua version 5.4

Closes: https://bugs.gentoo.org/504876
Signed-off-by: Jocelyn-MAYER <l_indien@mailmagic.fr>
Signed-off-by: Sam James <sam@gentoo.org>

@thesamesam thesamesam closed this Dec 29, 2022
@Jocelyn-MAYER
Copy link
Contributor Author

Sorry, I'm a newbie with github and I did all using the web interface, not command line at home.
Seems like I may have too...
I'll take a deeper look to the documentation about git usage for gento..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants