sci-calculators/bc-gh: update to 6.2.2

[gavinhoward]

This commit does two more things besides just update:

• The MissingRemoteId pkgcheck warning is resolved by adding the proper remote ID to metadata.xml.
• The readline and libedit USE flags are added since this bc now supports both as options.

In addition, this commit adds a message for users should readline and editline not work because I'm less confident in the code that supports them than the built-in history. This is a message that I (upstream) would like to have. However, if requested, I'll delete the message.

Signed-off-by: Gavin Howard gavin@yzena.com

[gentoo-bot]

Pull Request assignment

Submitter: @gavinhoward
Areas affected: ebuilds
Packages affected: sci-calculators/bc-gh

sci-calculators/bc-gh: gavin[at]yzena.com, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-01-01 05:23 UTC
Newest commit scanned: 6bc1d2b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/430d1797f2/output.html

[mgorny]

That said, the test suite fails for me:
sci-calculators:bc-gh-6.2.2:20230101-063322.log

I suppose 'Killed' means a timeout?

[gavinhoward]

That said, the test suite fails for me: sci-calculators:bc-gh-6.2.2:20230101-063322.log

I suppose 'Killed' means a timeout?

No, it usually means that the kernel OOM killer got to it. I have a few tests that try to force malloc() to return NULL, and since I have swap off on my machine, that's what it does on my machine. But on FreeBSD and on default Linux systems, malloc() still returns a valid pointer, at which point bc, which does not allocate anything it does not need, touches every single page of the allocation. This grows its memory usage until the OOM killer steps in.

There is an option to configure.sh to disable these tests, -P, and you probably didn't notice, but I added it to the configure.sh arguments in the ebuild. If you pull and try again, you should not get the "Killed" problem. If you do, that is a bug that I need to fix.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-01-01 18:23 UTC
Newest commit scanned: 60ed6ab
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d3683e83f6/output.html

[mgorny]

The tests pass for me now. Some more suggestions inline.

On a related note, a wish for a future release to make install-locale.sh more verbose because it takes very long here with no perceptible CPU use and it made me think that it hanged.

[gavinhoward]

The tests pass for me now. Some more suggestions inline.

On a related note, a wish for a future release to make install-locale.sh more verbose because it takes very long here with no perceptible CPU use and it made me think that it hanged.

Wish granted.

Also, I realized that the Gentoo package does not have a fix that the Arch package does. This is to set the environment to not use locales when doing testing because the old locales will still be used during testing, and that can cause crashes because of the misuse of printf() format specifiers.

So I added the src_test() function to do that. I'm sorry I didn't do it earlier.

[thesamesam]

Excellent, I've changed 'make check' -> 'emake check' to respect MAKEOPTS and also die on failure. Thank you!

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-01-01 21:13 UTC
Newest commit scanned: e8bdf33
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1a42dc361f/output.html