dev-libs/libbpf: Fix install in cross-compilation #28962
Conversation
Pull Request assignmentSubmitter: @zhuyifei1999 dev-libs/libbpf: @chutz, @jsmolic Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-01-04 19:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Without this patch install would cause: * Bad lib64 usage detected: drwxr-xr-x 3 root root 4.0K Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64 lrwxrwxrwx 1 root root 11 Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64/libbpf.so -> libbpf.so.1 lrwxrwxrwx 1 root root 15 Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64/libbpf.so.1 -> libbpf.so.1.0.1 -rwxr-xr-x 1 root root 889K Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64/libbpf.so.1.0.1 drwxr-xr-x 2 root root 4.0K Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64/pkgconfig -rw-r--r-- 1 root root 294 Jan 4 06:31 /build/target/tmp/portage/dev-libs/libbpf-1.0.1/image/usr/lib64/pkgconfig/libbpf.pc * This arch (arm) should never use 'lib64'. PR gentoo#28323 commit bd8d3b7 (dev-libs/libbpf: Fix install in prefix") removed declaration of LIBDIR because it is default-initialized to: LIBDIR ?= $(PREFIX)/$(LIBSUBDIR) However this causes regression because while we do set: export LIBSUBDIR="$(get_libdir)" This does not take effect in the Makefile, because it does either one of: LIBSUBDIR := lib64 LIBSUBDIR := lib Environment variables don't take precedence over variables from makefiles unless -e is given. To minimize other possible regressions I'm explicitly whitelisting LIBSUBDIR for precedence over that from makefile. Reported-by: Aashay Shringarpure <aashay@google.com> Signed-off-by: YiFei Zhu <zhuyifei@google.com>
zhuyifei1999
force-pushed
the
prefix-libbpf
branch
from
7a1d4f7
to
12565ed
Compare
Pull request CI reportReport generated at: 2023-01-05 04:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks for the solid explanation! |
Without this patch install would cause:
PR #28323 commit bd8d3b7 (dev-libs/libbpf: Fix install in prefix") removed declaration of LIBDIR because it is default-initialized to:
LIBDIR ?= $(PREFIX)/$(LIBSUBDIR)However this causes regression because while we do set:
export LIBSUBDIR="$(get_libdir)"This does not take effect in the Makefile, because it does either one of:
Environment variables don't take precedence over variables from makefiles unless -e is given. To minimize other possible regressions I'm explicitly whitelisting LIBSUBDIR for precedence over that from makefile.
Reported-by: Aashay Shringarpure aashay@google.com
Signed-off-by: YiFei Zhu zhuyifei@google.com