Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/starpu: add 1.3.10, drop 1.2.6-r1 #28973

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dev-libs/starpu: add 1.3.10, drop 1.2.6-r1 #28973

wants to merge 3 commits into from
+41 −24

Conversation

alexfanqi
Copy link
Contributor

@alexfanqi alexfanqi commented Jan 5, 2023 •
edited

version 1.2.6-r1 has multiple bugs that are fixed or not reproducible on 1.3, including
https://bugs.gentoo.org/show_bug.cgi?id=734088
https://bugs.gentoo.org/show_bug.cgi?id=743706
https://bugs.gentoo.org/show_bug.cgi?id=767148
https://bugs.gentoo.org/show_bug.cgi?id=666878

It would be good to drop it.
The only package requiring starpu 1.2.6 is pastix 5.2.3, but unluckily it is not compatible with 1.3.
https://bugs.gentoo.org/769779

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @alexfanqi
Areas affected: ebuilds
Packages affected: dev-libs/starpu

dev-libs/starpu: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jan 5, 2023
@alexfanqi alexfanqi force-pushed the starpu branch 3 times, most recently from a063fb2 to 39f7105 Compare January 5, 2023 13:53
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-05 14:13 UTC
Newest commit scanned: 39f7105
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9a5ab659cd/output.html

@alexfanqi
dev-libs/starpu: add 1.3.10
c21473d 
1. Port to EAPI 8
2. increase max managed cpus to 2x nproc to avoid oversubcribing tests
   failure
3. enable quick check, otherwise take too long with 2.

Signed-off-by: Alex Fan <alex.fan.q@gmail.com>
@alexfanqi
dev-libs/starpu: drop 1.2.6-r1
da875f7 
Signed-off-by: Alex Fan <alex.fan.q@gmail.com>
@alexfanqi
dev-libs/starpu: add myself as a maintainer
d59db5b 
Signed-off-by: Alex Fan <alex.fan.q@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-05 22:08 UTC
Newest commit scanned: d59db5b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5813520af6/output.html

@dlan17
Copy link
Contributor

dlan17 commented Jan 6, 2023

  1. please put "Closes" tag into commit messages, so it will resolve all relevant bugs
  2. for "starpu 1.2.6 is required by pastix 5.2.3", so removing starpu-1.2.6 will break pastix, I'd suggest either explicitly fix the dependency or drop both packages? at least don't break the ebuilds in tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
Milestone
No milestone
4 participants
@alexfanqi @gentoo-bot @gentoo-repo-qa-bot @dlan17