-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www-apps/hugo: add 0.110.0 #29069
www-apps/hugo: add 0.110.0 #29069
Conversation
Pull Request assignmentSubmitter: @tastytea www-apps/hugo: @tastytea, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-01-11 19:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
www-apps/hugo/hugo-0.109.0.ebuild
Outdated
src_test() { | ||
ego test -race "./..." ${MY_BUILDFLAGS} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> Test phase: www-apps/hugo-0.109.0
go test -race ./... -tags extended
-buildmode=pie not supported when -race is enabled
* ERROR: www-apps/hugo-0.109.0::gentoo failed (test phase)
No idea where the buildmode comes from, but you may have to strip flags when testing the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, i always get -buildmode=exe
and neither go-module.eclass nor the ebuild set -buildmode=pie
. I'm using 1.19.4 but it doesn't look like it changed in 1.19.5…
I guess i'll set -buildmode=exe
explicitly for tests for now. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the pie-problem, but forced -buildmode=exe
for tests and hope it'll fix it. 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-buildmode=pie
came from the eclass, by the way. → https://bugs.gentoo.org/702598
I couldn't reproduce because my tree was too old.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to just drop -race IMO. It's almost like using sanitizers or valgrind. It's not really appropriate for tests in ebuilds.
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
c372a89
to
a66c1c8
Compare
Pull request CI reportReport generated at: 2023-01-25 23:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de> Closes: gentoo#29069 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
0.109.0: 2 tests don't need to be disabled anymore, no other changes.
0.110.0: 1 additional test needs to be disabled (network access)