Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-apps/hugo: add 0.110.0 #29069

Closed
wants to merge 2 commits into from
Closed

Conversation

tastytea
Copy link
Contributor

@tastytea tastytea commented Jan 11, 2023

0.109.0: 2 tests don't need to be disabled anymore, no other changes.
0.110.0: 1 additional test needs to be disabled (network access)

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @tastytea
Areas affected: ebuilds
Packages affected: www-apps/hugo

www-apps/hugo: @tastytea, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jan 11, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-11 19:23 UTC
Newest commit scanned: c372a89
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f3a431813f/output.html

Comment on lines 74 to 76
src_test() {
ego test -race "./..." ${MY_BUILDFLAGS}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> Test phase: www-apps/hugo-0.109.0
go test -race ./... -tags extended
-buildmode=pie not supported when -race is enabled
 * ERROR: www-apps/hugo-0.109.0::gentoo failed (test phase)

No idea where the buildmode comes from, but you may have to strip flags when testing the package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, i always get -buildmode=exe and neither go-module.eclass nor the ebuild set -buildmode=pie. I'm using 1.19.4 but it doesn't look like it changed in 1.19.5

I guess i'll set -buildmode=exe explicitly for tests for now. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the pie-problem, but forced -buildmode=exe for tests and hope it'll fix it. 🤞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-buildmode=pie came from the eclass, by the way. → https://bugs.gentoo.org/702598
I couldn't reproduce because my tree was too old.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to just drop -race IMO. It's almost like using sanitizers or valgrind. It's not really appropriate for tests in ebuilds.

Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
@tastytea tastytea changed the title www-apps/hugo: add 0.109.0 www-apps/hugo: add 0.110.0 Jan 25, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-25 23:53 UTC
Newest commit scanned: a66c1c8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/90607a96e3/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tastytea tastytea deleted the www-apps/hugo branch January 29, 2023 09:21
freijon pushed a commit to freijon/gentoo that referenced this pull request Jan 31, 2023
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
Closes: gentoo#29069
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants