app-editors/retext: add 8.0.0, drop 7.2.2, update 9999 and add myself as maintainer #29070
Conversation
Pull Request assignmentSubmitter: @rndxelement app-editors/retext: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2023-01-11 22:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
|
||
| pkg_setup() { | ||
| # Needed for lrelease | ||
| export PATH="$(qt5_get_bindir):${PATH}" |
There was a problem hiding this comment.
I know the eclass isn't updated for qt6 yet, but will this work? Does this do what it's supposed to do?
That function itself is pretty simple to one-line outside the eclass if you just manually define it.
There was a problem hiding this comment.
Replacing it by export PATH="${EPREFIX}/usr/$(get_libdir)/qt6/bin:${PATH}" doesn't work unfortunately, because it needs the tool lrelease for translations from dev-qt/linguist-tools and the latest version in the tree is 5.15.8, so not qt6 compatible yet.
Using the above replacement results in Failed to build translations: [Errno 2] No such file or directory: 'lrelease' (no build failure though, it continues and finishes the build).
Interestingly, it seems to work with the qt5 binding, because using export PATH="$(qt5_get_bindir):${PATH}" results in no error. I couldn't test yet if the translations actually work even with the qt5 lrelease tool.
Maybe we can leave it as it is now, file a version bump bug for dev-qt/linguist-tools and a bug for app-editors/retext that depends on the version bump bug. What do you think?
There was a problem hiding this comment.
Well if it works :) But it sounds logical that an executable or headers don't need to be updated like libs.
| } | ||
|
|
||
| python_test() { | ||
| eunittest || die |
There was a problem hiding this comment.
This probably doesn't need to || die here, but remind me again is this added due to the virtx call above? I believe you can just call virtx eunittest too and it should work.
There was a problem hiding this comment.
virtx eunittest works like a charm, thanks!
From version 8.0.0 ReText uses PyQt6 and optionally PyQt6-WebEngine, therefore mask >=app-editors/retext-8.0.0 since dev-python/PyQt6 is also masked. Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
rndxelement
force-pushed
the
retext-8.0.0
branch
from
134b7c1
to
881c7e5
Compare
Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
rndxelement
force-pushed
the
retext-8.0.0
branch
from
881c7e5
to
b9e4015
Compare
Pull request CI reportReport generated at: 2023-01-26 21:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-01-26 22:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
|
||
| pkg_setup() { | ||
| # Needed for lrelease | ||
| export PATH="$(qt5_get_bindir):${PATH}" |
There was a problem hiding this comment.
Well if it works :) But it sounds logical that an executable or headers don't need to be updated like libs.
|
Could you fix this when you have some time? https://projects.gentoo.org/python/guide/distutils.html#the-pep-517-and-legacy-modes |
Signed-off-by: Philipp Rösner <rndxelement@protonmail.com> Closes: gentoo#29070 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
>=app-editors/retext-8.0.0now uses PyQt6 and PyQt6-WebEngine, see changelog>=app-editors/retext-8.0.0alphabetically to thepackage.maskfile