Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/hip: append -fno-stack-protector for hipcc #29188

Closed
wants to merge 1 commit into from

Conversation

littlewu2508
Copy link
Contributor

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: dev-util/hip

dev-util/hip: @gentoo/sci, @candrews, @justxi

Linked bugs

Bugs linked: 890377


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 20, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-20 10:28 UTC
Newest commit scanned: f801801
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f754eaf7c7/output.html

@thesamesam
Copy link
Member

This needs a new revision as it breaks it at runtime, right? (git mv is probably fine.)

Closes: https://bugs.gentoo.org/890377
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
Copy link
Contributor Author

This needs a new revision as it breaks it at runtime, right? (git mv is probably fine.)

You're right. Originally I thought it is breaking rocBLAS build issue so I did not bump revision. But for hip it's indeed runtime change.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-21 03:28 UTC
Newest commit scanned: 217963c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fb51cb8efd/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants