dev-lang/zig{,-bin}: slotting #29257

BratishkaErik · 2023-01-25T08:02:45Z

Wrote and tested 3 days so there should be errors that I could't catch.
Example of eselect zig list and eselect zig show:

Available Zig versions:
  [1]   zig-0.10.1 *
  [2]   zig-9999
  [3]   zig-bin-0.10.1

That are:

/usr/lib64/zig/0.10.1/bin/zig
/usr/lib64/zig/9999/bin/zig
/opt/zig-bin-0.10.1/zig

Current Zig version:
  zig-0.10.1

gentoo-bot · 2023-01-25T08:04:05Z

Pull Request assignment

Submitter: @BratishkaErik
Areas affected: ebuilds
Packages affected: app-eselect/eselect-zig, dev-lang/zig, dev-lang/zig-bin, sys-fs/ncdu

app-eselect/eselect-zig: @gentoo/proxy-maint (new package)
dev-lang/zig: @BratishkaErik, @gentoo/proxy-maint
dev-lang/zig-bin: @BratishkaErik, @gentoo/proxy-maint
sys-fs/ncdu: @jsmolic

Linked bugs

Bugs linked: 890234, 885861

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2023-01-25T08:13:19Z

Pull request CI report

Report generated at: 2023-01-25 08:13 UTC
Newest commit scanned: 9b5d719
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c16ef37985/output.html

BratishkaErik · 2023-01-25T09:33:28Z

Small fix + all tests passes so I replaced Bug: https://bugs.gentoo.org/885861 with Closes: https://bugs.gentoo.org/885861

gentoo-repo-qa-bot · 2023-01-25T09:53:12Z

Pull request CI report

Report generated at: 2023-01-25 09:53 UTC
Newest commit scanned: e55537f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6b26f111ac/output.html

Flowdalic · 2023-01-25T16:33:40Z

sys-fs/ncdu/ncdu-2.2.2-r1.ebuild

+src_configure() {
+	local zig_version
+	zig_version="$(zig version)"
+	[[ ${zig_version} =~ 0.10.? ]] || die "You should choose Zig version 0.10.x via eselect-zig, found instead: $(zig version)"


Couldn't the ebuild select automatically the correct zig version, instead of die'ing? See for example what the egradle function does in https://github.com/gentoo/gentoo/pull/28986/files#diff-62274241513f609709470a95a2d41d24f538e496f9415b2ef45553dfabfbab50R124.

FTR, the actual logic that sets EGRADLE is in https://github.com/gentoo/gentoo/pull/28986/files#diff-62274241513f609709470a95a2d41d24f538e496f9415b2ef45553dfabfbab50R59. Maybe this could be an inspiration for EZIG?

Sounds very interesting. So create eclass (and send to gentoo-dev ofc), then ebuilds inherit this eclass and use ezig and f.i. ZIG_SLOT? Or make it only in ncdu ebuild

Made it only for ncdu ebuild

BratishkaErik · 2023-02-01T15:54:34Z

I was fixing my PC today, so I'll continue tomorrow. BTW ziglang/zig#14498 Zig's package manager is growing...

gentoo-repo-qa-bot · 2023-02-04T12:53:04Z

Pull request CI report

Report generated at: 2023-02-04 12:53 UTC
Newest commit scanned: 9fdba29
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/57bbbdb865/output.html

BratishkaErik · 2023-02-04T14:28:14Z

@Flowdalic again thank you very much!

gentoo-repo-qa-bot · 2023-02-04T14:38:07Z

Pull request CI report

Report generated at: 2023-02-04 14:38 UTC
Newest commit scanned: 1137216
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/57f17fc5d2/output.html

BratishkaErik · 2023-02-08T17:44:58Z

pong

gentoo-repo-qa-bot · 2023-02-15T16:28:20Z

Pull request CI report

Report generated at: 2023-02-15 16:28 UTC
Newest commit scanned: b9bb750
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f18ab6d370/output.html

Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

* Install Zig to "/usr/$(get_libdir)/zig/${PV}", handle /usr/bin/zig via eselect-zig * Add functions for getting ZIG_TARGET and ZIG_MCPU (user-provided or defaults) and use them for building/testing * Add "doc" USE flag for installing language reference and stdlib documentation Closes: https://bugs.gentoo.org/885861 Bug: https://bugs.gentoo.org/890234 Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

* Slot Zig and handle /usr/bin/zig via eselect-zig * Add "doc" USE flag for installing language reference and stdlib documentation Followup to previous commit 6ea1aff. Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

gentoo-repo-qa-bot · 2023-02-18T13:08:13Z

Pull request CI report

Report generated at: 2023-02-18 13:08 UTC
Newest commit scanned: 9304e97
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/398ccdcc1b/output.html

BratishkaErik · 2023-03-05T13:08:54Z

ping

Flowdalic

LGTM, only minor copy&paste issue.

Flowdalic · 2023-03-06T10:32:52Z

sys-fs/ncdu/ncdu-2.2.2-r1.ebuild

+	done
+
+	if [[ -z ${selected} ]]; then
+		die "Could not find (suitable) gradle installation in PATH"


Suggested change

die "Could not find (suitable) gradle installation in PATH"

die "Could not find (suitable) zig installation in PATH"

Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

gentoo-repo-qa-bot · 2023-03-06T13:34:45Z

Pull request CI report

Report generated at: 2023-03-06 13:34 UTC
Newest commit scanned: 0e02f00
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/84d58e931b/output.html

Flowdalic · 2023-03-09T10:55:51Z

Thank you very much for your contribution and sorry that it took so long to get it merged.

Please note that I made some minor changes to improve zig's sollting, especially adding an 'update' action to the eselect module. See 712edec and its predecessor commits.

BratishkaErik · 2023-03-09T11:51:01Z

Thank you very much for your contribution and sorry that it took so long to get it merged.
Please note that I made some minor changes to improve zig's sollting, especially adding an 'update' action to the eselect module. See 712edec and its predecessor commits.

Thanks, IMHO these changes are more risky (?) so it's kinda expectable to took so long? IDK. Again, huge thanks!

BratishkaErik · 2023-03-09T11:51:46Z

I'll make some changes in wiki too.

gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 25, 2023

thesamesam requested a review from jsmolic January 25, 2023 08:09

BratishkaErik force-pushed the zig-slooted branch from 9b5d719 to e55537f Compare January 25, 2023 09:32

Flowdalic reviewed Jan 25, 2023

View reviewed changes

BratishkaErik force-pushed the zig-slooted branch from e55537f to 9fdba29 Compare February 4, 2023 12:44

BratishkaErik force-pushed the zig-slooted branch 2 times, most recently from 1e6368c to 1137216 Compare February 4, 2023 14:25

BratishkaErik force-pushed the zig-slooted branch from 1137216 to b9bb750 Compare February 15, 2023 16:16

BratishkaErik added 3 commits February 18, 2023 18:56

app-eselect/eselect-zig: new package, add 1

9329363

Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

dev-lang/zig-bin: slotting

712b0f1

* Slot Zig and handle /usr/bin/zig via eselect-zig * Add "doc" USE flag for installing language reference and stdlib documentation Followup to previous commit 6ea1aff. Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

BratishkaErik force-pushed the zig-slooted branch from b9bb750 to 9304e97 Compare February 18, 2023 12:56

Flowdalic suggested changes Mar 6, 2023

View reviewed changes

sys-fs/ncdu: adjust ebuild for slotted Zig

0e02f00

Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

BratishkaErik force-pushed the zig-slooted branch from 9304e97 to 0e02f00 Compare March 6, 2023 13:23

jsmolic approved these changes Mar 6, 2023

View reviewed changes

gentoo-bot closed this in 195bde1 Mar 9, 2023

BratishkaErik deleted the zig-slooted branch March 9, 2023 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-lang/zig{,-bin}: slotting #29257

dev-lang/zig{,-bin}: slotting #29257

BratishkaErik commented Jan 25, 2023 •

edited

gentoo-bot commented Jan 25, 2023

gentoo-repo-qa-bot commented Jan 25, 2023

BratishkaErik commented Jan 25, 2023

gentoo-repo-qa-bot commented Jan 25, 2023

Flowdalic Jan 25, 2023

Flowdalic Jan 25, 2023

BratishkaErik Jan 25, 2023 •

edited

BratishkaErik Feb 4, 2023

BratishkaErik commented Feb 1, 2023

gentoo-repo-qa-bot commented Feb 4, 2023

BratishkaErik commented Feb 4, 2023

gentoo-repo-qa-bot commented Feb 4, 2023

BratishkaErik commented Feb 8, 2023 •

edited

gentoo-repo-qa-bot commented Feb 15, 2023

gentoo-repo-qa-bot commented Feb 18, 2023

BratishkaErik commented Mar 5, 2023

Flowdalic left a comment

Flowdalic Mar 6, 2023

gentoo-repo-qa-bot commented Mar 6, 2023

Flowdalic commented Mar 9, 2023

BratishkaErik commented Mar 9, 2023

BratishkaErik commented Mar 9, 2023

	die "Could not find (suitable) gradle installation in PATH"
	die "Could not find (suitable) zig installation in PATH"

dev-lang/zig{,-bin}: slotting #29257

dev-lang/zig{,-bin}: slotting #29257

Conversation

BratishkaErik commented Jan 25, 2023 • edited

gentoo-bot commented Jan 25, 2023

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jan 25, 2023

Pull request CI report

BratishkaErik commented Jan 25, 2023

gentoo-repo-qa-bot commented Jan 25, 2023

Pull request CI report

Flowdalic Jan 25, 2023

Choose a reason for hiding this comment

Flowdalic Jan 25, 2023

Choose a reason for hiding this comment

BratishkaErik Jan 25, 2023 • edited

Choose a reason for hiding this comment

BratishkaErik Feb 4, 2023

Choose a reason for hiding this comment

BratishkaErik commented Feb 1, 2023

gentoo-repo-qa-bot commented Feb 4, 2023

Pull request CI report

BratishkaErik commented Feb 4, 2023

gentoo-repo-qa-bot commented Feb 4, 2023

Pull request CI report

BratishkaErik commented Feb 8, 2023 • edited

gentoo-repo-qa-bot commented Feb 15, 2023

Pull request CI report

gentoo-repo-qa-bot commented Feb 18, 2023

Pull request CI report

BratishkaErik commented Mar 5, 2023

Flowdalic left a comment

Choose a reason for hiding this comment

Flowdalic Mar 6, 2023

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Mar 6, 2023

Pull request CI report

Flowdalic commented Mar 9, 2023

BratishkaErik commented Mar 9, 2023

BratishkaErik commented Mar 9, 2023

BratishkaErik commented Jan 25, 2023 •

edited

BratishkaErik Jan 25, 2023 •

edited

BratishkaErik commented Feb 8, 2023 •

edited