Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-shells/nushell Removed 'extra' USE flag, added 'dataframe' USE flag #29352

Closed
wants to merge 2 commits into from

Conversation

freijon
Copy link
Contributor

@freijon freijon commented Jan 31, 2023

As described in the Changelog 0.72 the feature extra no longer contains extra features. In fact, if you look at Cargo.toml, you'll find that extra is the same as stable or default:

# extra used to be more useful but now it's the same as default. Leaving it in for backcompat with existing build scripts
extra = ["default"]
default = ["plugin", "which-support", "trash-support", "sqlite"]
stable = ["default"]
wasi = []

Also, the feature dataframe is now optional, see reasoning.

I therefore propose to remove the extra USE flag and introduce the new USE flag dataframe (disabled by default, as per upstream)

…d 'dataframe' and 'sqlite' USE flags.

Signed-off-by: Jonas Frei <freijon@pm.me>
…vided by default

Signed-off-by: Jonas Frei <freijon@pm.me>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @freijon
Areas affected: ebuilds
Packages affected: app-shells/nushell

app-shells/nushell: @zmedico

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 31, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-31 06:23 UTC
Newest commit scanned: cfaf88c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5f19985d48/output.html

@gentoo-bot gentoo-bot closed this in 937cbe7 Feb 1, 2023
@zmedico
Copy link
Member

zmedico commented Feb 1, 2023

Thanks!

@freijon freijon deleted the nushell branch July 12, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants