sys-libs/liburing: Add use flags for building examples and testing #29563
Conversation
Pull Request assignmentSubmitter: @stwnt sys-libs/liburing: @Flowdalic Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-02-12 23:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
By default liburing will build tests and examples but these fail to build on musl systems so we sed them out if not needed. Closes: https://bugs.gentoo.org/888956 Signed-off-by: Steffen Winter <steffen.winter@proton.me>
Pull request CI reportReport generated at: 2023-02-12 23:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -39,6 +39,13 @@ src_prepare() { | |||
| sed -i "/^Version:/s@[[:digit:]\.]\+@${PV}@" ${PN}.spec || die | |||
| fi | |||
|
|
|||
| if ! use examples; then | |||
There was a problem hiding this comment.
Should we force this by adding something like if use elibc_musl || ! use examples; then?
There was a problem hiding this comment.
It's a good question, but it's something we should do in profiles/ instead (in profiles/features/musl/package.use.mask).
By default liburing will build tests and examples but these fail to build on musl systems so we sed them out if not needed.
@thesamesam
Closes: https://bugs.gentoo.org/888956
Signed-off-by: Steffen Winter steffen.winter@proton.me