java-utils-2.eclass: default to default_src_prepare for future EAPI #29626
Conversation
Presently patches from a PATCHES array are not getting applied unless
"default" or "eapply_user" is set in the ebuild. In cases where nothing
else needs to be prepared it still needs src_prepare in the ebuild
src_prepare() {
default
}
With this change, starting from EAPI 9 this will no longer be needed. In
cases where any other changes are done in the prepare phase it would only
need java-pkg-2_src_prepare be added:
src_prepare() {
java-pkg-2_src_prepare
cp, rm, mv, sed or other changes
}
Bug: https://bugs.gentoo.org/780585
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
according to man page, -wholename is less portable than -path. Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Pull Request assignmentSubmitter: @vaukai @gentoo/github Linked bugsBugs linked: 780585 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2023-02-17 10:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@fordfrog
There are more cleanup and documentation works on
java-utils-2.eclassin the first commit of ezzieyguywuf's #20608. These could now be adopted. There are 2 or 3 merge conflicts which could easily be solved.PR #20608 could then be closed since all
ebuildreworks can be done later with the EAPI bumps.