Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-php/pecl-imagick: remove dependency limiting use openmp in imagemagick. #29732

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

inode64
Copy link
Contributor

@inode64 inode64 commented Feb 22, 2023

remove dependency limiting use openmp in imagemagick.
Since version 3.5.1RC1 correctly manages its use.
I have been using it on my web servers ever since and without any problem.

pkgcheck 0.10.22
Portage 3.0.44

Signed-off-by: INODE64 <ffelix@inode64.com>
Since version 3.5.1RC1 correctly manages its use.
I have been using it on my web servers ever since and without any problem.

pkgcheck 0.10.22
Portage 3.0.44

Signed-off-by: INODE64 <ffelix@inode64.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @inode64
Areas affected: ebuilds
Packages affected: dev-php/pecl-imagick

dev-php/pecl-imagick: [php-bugs (project)], @orlitzky

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Feb 22, 2023
@orlitzky
Copy link
Contributor

People have been saying that this works again on https://bugs.gentoo.org/547922 so I'm fine with giving it a try. Please merge the two commits though!

Since version 3.5.1RC1 correctly manages its use.
I have been using it on my web servers ever since and without any problem.

pkgcheck 0.10.22
Portage 3.0.44

Signed-off-by: INODE64 <ffelix@inode64.com>
@orlitzky
Copy link
Contributor

Thanks. I'd like to use your actual commit for this (so that you get credit) but first there are some details that need cleaned up.

First, the commit message. All of our commit messages start with a cat/package: prefix indicating the package modified, and a short (less than 72 characters I think) summary. Afterwards you can explain in some detail what has been changed. We also use Bug: and Closes: tags to reference Gentoo bugs and pull requests. So in this case, I think you should put Bug: https://bugs.gentoo.org/547922 and Closes: https://github.com/gentoo/gentoo/pull/29732 at the bottom of your last commit.

We have a tool called pkgdev (you can install it with portage) that makes this easier. Usually I run something like pkgdev manifest; git add ./; pkgdev commit and the last command will generate a commit summary for you.

Next is that the KEYWORDS all need to be moved back to ~arch for the new revision. This was caught by pkgcheck, a QA tool that is also in portage and that you should also run with pkgcheck scan --commits to catch any errors.

Finally, it's not a big deal in this case, but to eliminate old commits from the PR you can use e.g. git rebase -i <old commit> where <old commit> is the first commit (going backwards) that you don't want to mess with. Git will open up a text editor and show you a list of commits, and you can choose to delete, squash or reword them as necessary.

The commit summary and the stable keywords are preventing this from being merge-able right now but if you get those sorted out we should be good.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-02-22 19:24 UTC
Newest commit scanned: 0ae8048
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/72647b7c2b/output.html

@inode64
Copy link
Contributor Author

inode64 commented Feb 22, 2023

I use phpstorm to edit the ebuilds
Yes, you're right, I forgot to activate the keywords

Package-Manager: Portage-3.0.41-r2, pkgcheck-0.10.20
Signed-off-by: Fco Javier Felix <ffelix@inode64.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-02-23 17:39 UTC
Newest commit scanned: b2ea80f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ebea4ae712/output.html

@orlitzky
Copy link
Contributor

orlitzky commented Mar 8, 2023

Sorry for the delay!

Can you squash these six commits into one using git rebase -i? Now
that there are a few important ones it's no longer possible for me to
cherry-pick only the latest, and we don't like to have intermediate
commits in the official repository.

The (only) commit message also has to follow a specific format or it
will get rejected. The format is described at,

https://devmanual.gentoo.org/ebuild-maintenance/git/index.html

along with a few other tricks. In particular you should try to use
pkgcheck to verify that your (only) commit doesn't have any other
issues that I might have overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants