java-pkg-simple.eclass: MANIFEST.MF show Gentoo in "Created-By: " #29801
Conversation
Pull Request assignmentSubmitter: @vaukai @gentoo/github Linked bugsBugs linked: 897786 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2023-02-26 09:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
eclass/java-pkg-simple.eclass
Outdated
| @@ -417,6 +417,7 @@ java-pkg-simple_src_compile() { | |||
| # package | |||
| local jar_args | |||
| if [[ -e ${classes}/META-INF/MANIFEST.MF ]]; then | |||
| sed '/Created-By: /d' -i ${classes}/META-INF/MANIFEST.MF | |||
There was a problem hiding this comment.
i found an info that headers in the manifest file, though should use first letters capital, are case insensitive, so we should make the regex case insensitive, to be sure it catches even some corner cases.
There was a problem hiding this comment.
i found an info that headers in the manifest file, though should use first letters capital, are case insensitive, so we should make the regex case insensitive, to be sure it catches even some corner cases.
/Id does the trick.
Presently, MANIFEST.MF can receive upstream's "Created-By:" if such line
is found in a predefined META-INF/MANIFEST.MF in ${JAVA_RESOURCE_DIRS}.
This change removes such line before the jar command creates the final
MANIFEST.MF putting "Created-By: (Gentoo)"
Closes: https://bugs.gentoo.org/897786
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Pull request CI reportReport generated at: 2023-02-27 08:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Presently, MANIFEST.MF can receive upstream's "Created-By:" if such line is found in a predefined META-INF/MANIFEST.MF in ${JAVA_RESOURCE_DIRS}. This change removes such line before the jar command creates the final MANIFEST.MF putting "Created-By: (GEntoo)"
Closes: https://bugs.gentoo.org/897786
@fordfrog