app-i18n/ibus-libpinyin : Fix quotes to build with sqlite3.41 (also python compat & cleanup) #29937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Graham Ramsey <graham.ramsey@gmail.com>
…update Bug: https://bugs.gentoo.org/896574 Signed-off-by: Graham Ramsey <graham.ramsey@gmail.com>
sqlite has got more strict in latest version so it no longer accepts double quotes for sqlite string values. This adds a patch to replace double with single. There is an upstream attempt to fix this but it is not quite right so this doesn't copy it exactly. I have commented on the patch with advice. libpinyin/ibus-libpinyin@9604288 We cannot upgrade yet to this anyway, as we are dependant on older version of libpinyin. Bug: https://bugs.gentoo.org/898478 Signed-off-by: Graham Ramsey <graham.ramsey@gmail.com>
Pull request CI reportReport generated at: 2023-03-05 14:28 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes