Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/gobject-introspection, dev-libs/gobject-introspection-common: Version bump to 1.75.6 BETA #29967

Closed
wants to merge 2 commits into from

Conversation

flint2
Copy link
Contributor

@flint2 flint2 commented Mar 6, 2023

Need mask, in preparation for Gnome 44

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-07 00:08 UTC
Newest commit scanned: eb12b0e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1bc7884d6a/output.html

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @flint2
Areas affected: ebuilds, profiles
Packages affected: dev-libs/gobject-introspection, dev-libs/gobject-introspection-common

dev-libs/gobject-introspection: @gentoo/gnome
dev-libs/gobject-introspection-common: @gentoo/gnome

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 8, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-08 17:03 UTC
Newest commit scanned: 4bc3b83
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7f2cb7967e/output.html

@mattst88
Copy link
Contributor

mattst88 commented Mar 9, 2023

Dependency glib-2.0 found: NO found 2.74.6 but need: '>=2.75.0'

Please test the PRs. I know some things will slip through, and that's what review is for, but it's not a good use of reviewers' time to catch things like this.

@mattst88
Copy link
Contributor

Please test the PRs. I know some things will slip through, and that's what review is for, but it's not a good use of reviewers' time to catch things like this.

I was probably wrong to suggest that you hadn't tested this—I suspect you did and you just already had glib-2.75.4 installed since you already provided a PR for that. Sorry.

Something to note about gobject-introspection: the minor version should match the glib minor version. E.g. gobject-introspection-1.74 depends on glib-2.74, etc. It's not obvious from the build scripts, but here's the logic that controls it, in gobject-introspection's meson.build:

# Reset to 0 if g-i micro version exceeds GLib's
glib_micro_version = 0  # gi_version[2]
glib_version = '>=2.@0@.@1@'.format(gi_versions[1], glib_micro_version)

glib_dep = dependency('glib-2.0', version: glib_version,
                      default_options: ['tests=false'])

@flint2
Copy link
Contributor Author

flint2 commented Mar 10, 2023

introspection: the minor version should match the glib minor version. E.g. gobject-introspection-1.74 depends on glib-2.74, et

I did a quick test after installing, I've tried to follow the order of https://wiki.gentoo.org/wiki/Project:GNOME/GNOME_Bumping_Guide#glib for the PRs unless I hit a dependency and needed to change the order.
Will look into gobject-introspection issue later
Thanks!

Signed-off-by: Guillermo Joandet <gjoandet@gmail.com>
Signed-off-by: Guillermo Joandet <gjoandet@gmail.com>
@flint2 flint2 force-pushed the gobject-introspection-beta branch from 4bc3b83 to 57262d6 Compare March 10, 2023 15:27
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-10 15:38 UTC
Newest commit scanned: 57262d6
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/ab72977941/output.html#dev-libs/gobject-introspection

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ab72977941/output.html

@flint2
Copy link
Contributor Author

flint2 commented Mar 10, 2023

Removed mask, will do a PR with only one commit for masking all Gnome 44 BETA related packages

If glib 1.75 is a dependency, should be included in same PR?

What do you suggest?

@mattst88
Copy link
Contributor

If glib 1.75 is a dependency, should be included in same PR?

What do you suggest?

That's probably a good idea for the future.

@flint2 flint2 deleted the gobject-introspection-beta branch March 11, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants