Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-module.eclass: Fix linking with ld.lld #30009

Closed
wants to merge 1 commit into from

Conversation

alfredfo
Copy link
Contributor

@alfredfo alfredfo commented Mar 9, 2023

If LD is not specified then CCLD will be used as the linker. Setting CCLD to CC makes it correctly use LDFLAGS.

Bug: https://bugs.gentoo.org/261375

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @alfredfo
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 261375

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 9, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-09 00:33 UTC
Newest commit scanned: 1c26842
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1224213166/output.html

@thesamesam
Copy link
Member

Can you test this on a "vanilla" glibc system too without LD etc set? Perl has a history of being brittle here but I think this is the right move.

@alfredfo
Copy link
Contributor Author

alfredfo commented Mar 9, 2023

Can you test this on a "vanilla" glibc system too without LD etc set? Perl has a history of being brittle here but I think this is the right move.

Can set up a chroot and build some Perl stuff yep. I don't have a "vanilla" glibc/gcc system :(

If LD is not specified then CCLD will be used as the linker.
Setting CCLD to CC makes it correctly use LDFLAGS.

Bug: https://bugs.gentoo.org/261375
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
@alfredfo
Copy link
Contributor Author

alfredfo commented Mar 9, 2023

changed "Closes:" to "Bug:"

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-09 01:38 UTC
Newest commit scanned: f3840a6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/44a7ef7d40/output.html

Copy link
Member

@akhuettel akhuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
5 participants