Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail-filter/spamassassin: eautoreconf spamc #30200

Closed
wants to merge 1 commit into from

Conversation

Philippe23
Copy link
Contributor

@Philippe23 Philippe23 commented Mar 18, 2023

mail-filter/spamassassin: eautoreconf spamc

To deal with "implicit function declarations" in configure logs coming out of a standard autoconf test, run eautoreconf on spamc. Word is that the standard test is fixed in the next autoconf release, so this may not need to stick around for too long.

Closes: https://bugs.gentoo.org/899782
Closes: #30200


Diff against prev rev for ease of review:

--- spamassassin-4.0.0-r1.ebuild        2023-03-17 09:37:01.981615304 -0400
+++ spamassassin-4.0.0-r2.ebuild        2023-03-17 20:57:10.962793948 -0400
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit perl-functions systemd toolchain-funcs verify-sig
+inherit perl-functions systemd toolchain-funcs verify-sig autotools
 
 MY_P="Mail-SpamAssassin-${PV//_/-}"
 DESCRIPTION="An extensible mail filter which can identify and tag spam"
@@ -150,6 +150,13 @@
                || die 'failed to create a Makefile using Makefile.PL'
 
        # Now configure spamc.
+
+       # Run autoreconf to avoid some issues caused by a standard test in the
+       # current autoconf.  Expected to be fixed in next autoconf release, so
+       # these next 3 lines might not be needed for long.  See bug #899782.
+       pushd spamc >/dev/null
+       eautoreconf
+       popd >/dev/null
        emake CC="$(tc-getCC)" LDFLAGS="${LDFLAGS}" spamc/Makefile
 }

To deal with "implicit function declarations" in configure logs coming
out of a standard autoconf test, run eautoreconf on spamc.  Word is that
the standard test is fixed in the next autoconf release, so this may not
need to stick around for too long.

Closes: https://bugs.gentoo.org/899782
Closes: gentoo#30200
Signed-off-by: Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Philippe23
Areas affected: ebuilds
Packages affected: mail-filter/spamassassin

mail-filter/spamassassin: @Philippe23, @gentoo/proxy-maint

Linked bugs

Bugs linked: 899782


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 18, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-18 01:14 UTC
Newest commit scanned: 1f3e18b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/15faf9f940/output.html

@Philippe23 Philippe23 marked this pull request as ready for review March 18, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants