Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-java/batik: avoid file collisions #30431

Closed
wants to merge 1 commit into from
Closed

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Apr 1, 2023

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-01 11:23 UTC
Newest commit scanned: afacf53
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e3ce1ce7fd/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-01 11:33 UTC
Newest commit scanned: fb6f234
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a14257f5a6/output.html

@vaukai vaukai changed the title dev-java/batik: avoid file collisions dev-java/batik: avoid file collisions [please reassign] Apr 1, 2023
@fordfrog
Copy link
Contributor

fordfrog commented Apr 1, 2023

i guess we need a revbump for this as it affects installed files

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-01 16:03 UTC
Newest commit scanned: 5f323d7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6cf0fa82f3/output.html

@gentoo-bot gentoo-bot changed the title dev-java/batik: avoid file collisions [please reassign] dev-java/batik: avoid file collisions Apr 1, 2023
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 1, 2023
@vaukai vaukai changed the title dev-java/batik: avoid file collisions dev-java/batik: avoid file collisions [please reassign] Apr 2, 2023
@gentoo-bot gentoo-bot changed the title dev-java/batik: avoid file collisions [please reassign] dev-java/batik: avoid file collisions Apr 2, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/batik

dev-java/batik: @gentoo/java

Linked bugs

Bugs linked: 872689, 903641


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 2, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-02 06:48 UTC
Newest commit scanned: 9724697
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/479baa7487/output.html

Terminal=false
Type=Application
Categories=Graphics;VectorGraphics;
MimeType=image/svg+xml;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a new file for each bump or could we just tag the existing file and replace the version using sed from the ebuild?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a new file for each bump or could we just tag the existing file and replace the version using sed from the ebuild?

How should that work if more than one slot is installed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of version you put something like %VER% in the desktop file in files dir, you can also rename it to *.template if you want, and during installation you copy the file, sed the version in the copied file, and then you install the modified file using newmenu. you can see thunderbird ebuild for an example.

Copy link
Contributor Author

@vaukai vaukai Apr 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'v seen in ps3mediaserver-1.90.1-r2.ebuild looks promising. Will try that.

@vaukai vaukai marked this pull request as draft April 2, 2023 12:33
Bug: https://bugs.gentoo.org/872689
Closes: https://bugs.gentoo.org/903641
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai marked this pull request as ready for review April 2, 2023 13:33
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-02 13:43 UTC
Newest commit scanned: 563ceba
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ab66f35b3c/output.html

@gentoo-bot gentoo-bot closed this in 96f1b92 Apr 3, 2023
@vaukai vaukai deleted the batik branch April 3, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues
Projects
None yet
4 participants