qmail.eclass: Patch make-makelib.sh only if it is present #30456
Conversation
Some packages use qmail_set_cc function but they don't contain make-makelib.sh script. However, recent addition of || die to the sed patching this file is newly triggering build failure. This commit addresses the problem by checking if the script is available. Closes: https://bugs.gentoo.org/902009 Closes: https://bugs.gentoo.org/902019 Fixes: fd4e88c ("qmail.eclass: remove EAPI 6") Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Pull Request assignmentSubmitter: @arkamar @gentoo/github Linked bugsNew packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2023-04-03 11:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Wouldn't this also close https://bugs.gentoo.org/902013 (that is, the bug that #30205 tries to fix by removing the call to |
|
Yes, this would also close https://bugs.gentoo.org/902013 but it is already resolved as a duplicate of https://bugs.gentoo.org/902009, hence I thought it is not necessary to add it to the list. #30205 is not currently correct solution of the issue, because Anyway, this issue affects two packages currently, also stable versions, it was triggered by a change in |
|
Thanks! |
Some packages use qmail_set_cc function but they don't contain make-makelib.sh script. However, recent addition of || die to the sed patching this file is newly triggering build failure. This commit addresses the problem by checking if the script is available.
Closes: https://bugs.gentoo.org/902009
Closes: https://bugs.gentoo.org/902019
Fixes: fd4e88c ("qmail.eclass: remove EAPI 6")
See also this PR #30205