Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-ruby/activejob: slot 7.0 add dev-ruby/zeitwerk test depend #30554

Closed
wants to merge 1 commit into from
Closed

dev-ruby/activejob: slot 7.0 add dev-ruby/zeitwerk test depend #30554

wants to merge 1 commit into from

Conversation

peeweep
Copy link
Contributor

@peeweep peeweep commented Apr 11, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @peeweep
Areas affected: ebuilds
Packages affected: dev-ruby/activejob

dev-ruby/activejob: @gentoo/ruby

Linked bugs

Bugs linked: 904164

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 11, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-11 11:33 UTC
Newest commit scanned: 0393421
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/358cb86096/output.html

@graaff
Copy link
Member

graaff commented Apr 16, 2023

This wasn't a problem with activejob 6.1 because at that time zeitwerk was a dependency of activesupport, but zeitwerk has been moved to railties now. In any case activejob tests depend directly on zeitwerk so adding this dependency is the correct fix.

Thanks!

@graaff graaff closed this Apr 16, 2023
@graaff graaff self-assigned this Apr 16, 2023
@peeweep peeweep deleted the activejob-tests branch April 16, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@graaff graaff

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@peeweep @gentoo-bot @gentoo-repo-qa-bot @graaff