Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-analyzer/ettercap: Fix musl build #30577

Closed
wants to merge 1 commit into from
Closed

net-analyzer/ettercap: Fix musl build #30577

wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Apr 13, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: net-analyzer/ettercap

net-analyzer/ettercap: @ZeroChaos-, @asarubbo, @gentoo/netmon

Linked bugs

Bugs linked: 897820

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 13, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-13 02:08 UTC
Newest commit scanned: b148640
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9f92ff8478/output.html

thesamesam
thesamesam reviewed Apr 13, 2023
View reviewed changes
net-analyzer/ettercap/files/ettercap-0.8.3.1-musl.patch
Subject: [PATCH] Define _GNU_SOURCE to make sure memmem is found when musl
library is used. This fixes issue: #1219

Thanks Sam James for the suggestion!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

gentoo-bot pushed a commit to gentoo/libressl that referenced this pull request Apr 13, 2023
@orbea
net-analyzer/ettercap: add 0.8.3.1-r2
168e122 
Includes Gentoo PR: gentoo/gentoo#30577

Signed-off-by: orbea <orbea@riseup.net>
@orbea
net-analyzer/ettercap: Fix musl build
acdbfb1 
Closes: https://bugs.gentoo.org/897820
Upsream-PR: Ettercap/ettercap#1220
Uptream-Commit: Ettercap/ettercap@f03a117

Signed-off-by: orbea <orbea@riseup.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-13 03:13 UTC
Newest commit scanned: acdbfb1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7e8bd4c983/output.html

@orbea orbea deleted the ettercap branch April 14, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

@ZeroChaos- ZeroChaos- ZeroChaos- approved these changes

@asarubbo asarubbo Awaiting requested review from asarubbo

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@orbea @gentoo-bot @gentoo-repo-qa-bot @ZeroChaos- @thesamesam