dev-util/patchelf: Add define for DT_MIPS_XHASH

[LinuxUserGD]

dev-util/patchelf: Add define for DT_MIPS_XHASH

For musl libc the bundled elf.h header file is replaced with DT_MIPS_XHASH define using regex
(alternative approach to https://bugs.gentoo.org/860888#c14 which patches the if branch directly).

Closes: https://bugs.gentoo.org/860888

[gentoo-bot]

Pull Request assignment

Submitter: @LinuxUserGD
Areas affected: ebuilds
Packages affected: dev-util/patchelf

dev-util/patchelf: @chewi

Linked bugs

Bugs linked: 860888

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-15 17:03 UTC
Newest commit scanned: 09e763a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c949a9eadc/output.html

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-15 17:13 UTC
Newest commit scanned: cffe896
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d428bc4d37/output.html

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-24 18:28 UTC
Newest commit scanned: 785d31d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/215562d8c0/output.html

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-24 18:48 UTC
Newest commit scanned: eb18c97
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/510e710629/output.html

[chewi]

I'd much rather do this with a patch and eapply. That sed is quite awkward and could easily break.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-26 12:08 UTC
Newest commit scanned: 359ee59
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/caaebff0ab/output.html

[LinuxUserGD]

I'd much rather do this with a patch and eapply. That sed is quite awkward and could easily break.

Ok, I've added the patch after rm command.
Also removed use elibc_musl so it could apply to different libc elf.h headers too (or should I keep the condition?).

[chewi]

Ah sorry, if you're not going to make it conditional then it should be applied with this instead:

PATCHES=(
	"${FILESDIR}"/${PN}-glibc-dt-mips-xhash.patch
)

src_prepare() {
	rm src/elf.h || die
	default
}

default is where it applies the patches, so it'll do that after the rm. I think making it unconditional is fine and we generally prefer that anyway.

I must admit I'm not keen on #include <../include/elf.h>. It feels like a huge hack. I would prefer #include_next <elf.h>. It's supported by at least GCC and Clang. Clang emits a warning about it, but I'm not sure why, and I think I still prefer it over the alternative.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2023-04-26 22:23 UTC
Newest commit scanned: b3bc90b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/22ba102295/output.html