Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/skypeforlinux: use .DEB build as source due to checksum errors with RPM build #30657

Closed
wants to merge 1 commit into from
Closed

net-im/skypeforlinux: use .DEB build as source due to checksum errors with RPM build #30657

wants to merge 1 commit into from

Conversation

V3n3RiX
Copy link
Contributor

@V3n3RiX V3n3RiX commented Apr 19, 2023

Closes: https://bugs.gentoo.org/904352
Signed-of-by: Ghiunhan Mamut venerix@redcorelinux.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @V3n3RiX
Areas affected: ebuilds
Packages affected: net-im/skypeforlinux

net-im/skypeforlinux: @SoapGentoo

Linked bugs

Bugs linked: 904352

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Apr 19, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-19 21:58 UTC
Newest commit scanned: 1d2ebb1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0e6f1ae361/output.html

@thesamesam
Copy link
Member

Signed-of-by

This should be Signed-off-by, you can do it using git commit --signoff or git commit -s.

net-im/skypeforlinux: use .DEB build as source due to checksum errors…
6d437fb 
… with RPM build

Closes: https://bugs.gentoo.org/904352
Signed-off-by: Ghiunhan Mamut <venerix@redcorelinux.org>
@V3n3RiX
Copy link
Contributor Author

V3n3RiX commented Apr 21, 2023

Signed-of-by

This should be Signed-off-by, you can do it using git commit --signoff or git commit -s.

Thank you for your review, I fixed the typo, and I learned something new. Didn't know about the git commit --signoff.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-21 23:58 UTC
Newest commit scanned: 6d437fb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/94c4a76a51/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
Milestone
No milestone
4 participants
@V3n3RiX @gentoo-bot @gentoo-repo-qa-bot @thesamesam