dev-java/protobuf-java: add 3.23.0 #30860

vaukai · 2023-05-03T16:48:48Z

No description provided.

gentoo-repo-qa-bot · 2023-05-03T16:58:40Z

Pull request CI report

Report generated at: 2023-05-03 16:58 UTC
Newest commit scanned: ed80b32
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0df85f14ad/output.html

fordfrog · 2023-05-04T06:46:04Z

dev-java/protobuf-java/files/protobuf-java-3.22.3-ignore-failing-tests.patch

+java.lang.RuntimeException: Tests data file /google/protobuf/testdata/golden_packed_fields_message is missing.
+        at com.google.protobuf.TestUtil.readBytesFromResource(TestUtil.java:3848)
+        at com.google.protobuf.TestUtil.getGoldenPackedFieldsMessage(TestUtil.java:3881)
+        at com.google.protobuf.CodedOutputStreamTest.testWriteWholePackedFieldsMessage(CodedOutputStreamTest.java:382)


both these files should be part of a jar so that java can read them as resources. within the jar file the paths should be those as specified in the error. are they really missing from the distributed files or are they just missing in a jar?

Done. Those files were in a different directory and adding that directory to JAVA_TEST_RESOURCE_DIRS didn't help. Having them in testdata.jar finally works

gentoo-repo-qa-bot · 2023-05-04T08:48:35Z

Pull request CI report

Report generated at: 2023-05-04 08:48 UTC
Newest commit scanned: 07cd145
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/707c465bb5/output.html

gentoo-repo-qa-bot · 2023-05-04T16:38:47Z

Pull request CI report

Report generated at: 2023-05-04 16:38 UTC
Newest commit scanned: 47ab56a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0ab4f92629/output.html

gentoo-repo-qa-bot · 2023-05-04T18:53:39Z

Pull request CI report

Report generated at: 2023-05-04 18:53 UTC
Newest commit scanned: 24228e7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/617198a553/output.html

gentoo-repo-qa-bot · 2023-05-05T09:53:53Z

Pull request CI report

Report generated at: 2023-05-05 09:53 UTC
Newest commit scanned: 4cb442c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/98de09f840/output.html

gentoo-repo-qa-bot · 2023-05-06T08:53:58Z

Pull request CI report

Report generated at: 2023-05-06 08:53 UTC
Newest commit scanned: 8438482
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ff1c284d16/output.html

gentoo-repo-qa-bot · 2023-05-08T21:19:18Z

Pull request CI report

Report generated at: 2023-05-08 21:19 UTC
Newest commit scanned: e6265a1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/145065e6e4/output.html

vaukai · 2023-05-17T19:02:21Z

3.23.1 Protobuf only supports Abseil version 20230125.3 and newer.

gentoo-bot · 2023-06-27T16:28:07Z

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds, profiles
Packages affected: dev-java/protobuf-java

dev-java/protobuf-java: @Arfrever, @gentoo/cjk, @gentoo/java

Linked bugs

Bugs linked: 906811

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2023-06-27T16:41:46Z

Pull request CI report

Report generated at: 2023-06-27 16:41 UTC
Newest commit scanned: 8fdcede
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/14826b1d58/output.html

fordfrog · 2023-06-28T07:20:49Z

it depends on dev-java/protobuf-23.0 which is not in the tree yet

vaukai · 2023-06-28T07:28:54Z

it depends on dev-java/protobuf-23.0 which is not in the tree yet

That's the reason why we're building protoc locally if USE=-system-protoc.
The system-protoc USE flag gets masked in the second commit.

fordfrog · 2023-06-28T07:30:24Z

ah, well, the mask commit did not apply cleanly so i had to edit it but i might had done that wrongly...

Higher versions depend on dev-cpp/abseil-cpp-20230125.3 which is not in the tree. Bug: https://bugs.gentoo.org/906811 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

vaukai · 2023-06-28T07:38:21Z

ah, well, the mask commit did not apply cleanly so i had to edit it but i might had done that wrongly...

Sorry for inconvenience. I just rebased and solved the merge conflict.

gentoo-repo-qa-bot · 2023-06-28T08:00:13Z

Pull request CI report

Report generated at: 2023-06-28 08:00 UTC
Newest commit scanned: 294dc4f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/38f71434d5/output.html

fordfrog · 2023-06-28T08:07:07Z

@vaukai thanks!

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 3, 2023

fordfrog reviewed May 4, 2023

View reviewed changes

vaukai force-pushed the protobuf-java branch from ed80b32 to 07cd145 Compare May 4, 2023 08:36

vaukai force-pushed the protobuf-java branch from 07cd145 to 47ab56a Compare May 4, 2023 16:26

vaukai force-pushed the protobuf-java branch from 47ab56a to 24228e7 Compare May 4, 2023 18:44

vaukai force-pushed the protobuf-java branch from 24228e7 to 4cb442c Compare May 5, 2023 09:44

vaukai changed the title ~~dev-java/protobuf-java: add 3.22.3~~ dev-java/protobuf-java: add 3.22.4 May 5, 2023

vaukai force-pushed the protobuf-java branch from 4cb442c to 8438482 Compare May 6, 2023 08:41

vaukai force-pushed the protobuf-java branch from 8438482 to e6265a1 Compare May 8, 2023 21:07

vaukai changed the title ~~dev-java/protobuf-java: add 3.22.4~~ dev-java/protobuf-java: add 3.23.0 May 8, 2023

vaukai force-pushed the protobuf-java branch from e6265a1 to 8fdcede Compare June 27, 2023 16:25

vaukai changed the title ~~dev-java/protobuf-java: add 3.23.0~~ dev-java/protobuf-java: add 3.23.0 [please reassign] Jun 27, 2023

gentoo-bot changed the title ~~dev-java/protobuf-java: add 3.23.0 [please reassign]~~ dev-java/protobuf-java: add 3.23.0 Jun 27, 2023

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 27, 2023

vaukai added 2 commits June 28, 2023 09:34

dev-java/protobuf-java: add 3.23.0

37d28d1

Higher versions depend on dev-cpp/abseil-cpp-20230125.3 which is not in the tree. Bug: https://bugs.gentoo.org/906811 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

profiles/base: mask USE=system-protoc on dev-java/protobuf-java

294dc4f

Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

vaukai force-pushed the protobuf-java branch from 8fdcede to 294dc4f Compare June 28, 2023 07:36

gentoo-bot closed this in 6b5083a Jun 28, 2023

vaukai deleted the protobuf-java branch June 28, 2023 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-java/protobuf-java: add 3.23.0 #30860

dev-java/protobuf-java: add 3.23.0 #30860

vaukai commented May 3, 2023

gentoo-repo-qa-bot commented May 3, 2023

fordfrog May 4, 2023

vaukai May 4, 2023 •

edited

gentoo-repo-qa-bot commented May 4, 2023

gentoo-repo-qa-bot commented May 4, 2023

gentoo-repo-qa-bot commented May 4, 2023

gentoo-repo-qa-bot commented May 5, 2023

gentoo-repo-qa-bot commented May 6, 2023

gentoo-repo-qa-bot commented May 8, 2023

vaukai commented May 17, 2023

gentoo-bot commented Jun 27, 2023

gentoo-repo-qa-bot commented Jun 27, 2023

fordfrog commented Jun 28, 2023

vaukai commented Jun 28, 2023

fordfrog commented Jun 28, 2023 •

edited

vaukai commented Jun 28, 2023

gentoo-repo-qa-bot commented Jun 28, 2023

fordfrog commented Jun 28, 2023

dev-java/protobuf-java: add 3.23.0 #30860

dev-java/protobuf-java: add 3.23.0 #30860

Conversation

vaukai commented May 3, 2023

gentoo-repo-qa-bot commented May 3, 2023

Pull request CI report

fordfrog May 4, 2023

Choose a reason for hiding this comment

vaukai May 4, 2023 • edited

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented May 4, 2023

Pull request CI report

gentoo-repo-qa-bot commented May 4, 2023

Pull request CI report

gentoo-repo-qa-bot commented May 4, 2023

Pull request CI report

gentoo-repo-qa-bot commented May 5, 2023

Pull request CI report

gentoo-repo-qa-bot commented May 6, 2023

Pull request CI report

gentoo-repo-qa-bot commented May 8, 2023

Pull request CI report

vaukai commented May 17, 2023

gentoo-bot commented Jun 27, 2023

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jun 27, 2023

Pull request CI report

fordfrog commented Jun 28, 2023

vaukai commented Jun 28, 2023

fordfrog commented Jun 28, 2023 • edited

vaukai commented Jun 28, 2023

gentoo-repo-qa-bot commented Jun 28, 2023

Pull request CI report

fordfrog commented Jun 28, 2023

vaukai May 4, 2023 •

edited

fordfrog commented Jun 28, 2023 •

edited