gui-libs/wlroots: rework backends system, fix building with seatd #31028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request assignmentSubmitter: @BalkanMadman gui-libs/wlroots: @arthurzam, @prometheanfire Linked bugsBugs linked: 883781 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-05-14 00:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
oh god I messed it up |
BalkanMadman
force-pushed
the
wlroots-bug883781
branch
from
0b09afc
to
0890275
Compare
Pull request CI reportReport generated at: 2023-05-14 00:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
No more development or packaging for 7.4 branch. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
…tartup delay with USE=-activities Signed-off-by: Maciej Mrozowski <reavertm@gentoo.org> Bug: https://bugs.gentoo.org/906170
Bug: https://bugs.gentoo.org/895900 Bug: https://bugs.gentoo.org/891839 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Closes: https://bugs.gentoo.org/906208 Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
Closes: https://bugs.gentoo.org/903665 Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
The headers are needed to get Valgrind annotations. Signed-off-by: Sam James <sam@gentoo.org>
The headers are needed to get Valgrind annotations. Signed-off-by: Sam James <sam@gentoo.org>
We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James <sam@gentoo.org>
We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James <sam@gentoo.org>
We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James <sam@gentoo.org>
We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
The headers are needed to get Valgrind annotations. Signed-off-by: Sam James <sam@gentoo.org>
|
holy shit save me from this |
|
Will create a new pull |
Pull request CI reportReport generated at: 2023-05-14 01:13 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the initial issue was in compilation failure if seatd USE flag was disabled - it didn't do anything (in wlroots <=0.16.2 seatd is mandatory). In 9999 version it is optional, though, but is required for DRM and libinput, so I reworked backends system a bit.
I have done a bit of a testing - all the ebuilds for wlroots (even the ones I haven't touched) were successfuly recompiled (except for unsatisfying required USE) with any combination of the following USE flags I added: drm, libinput, session.
Bug: https://bugs.gentoo.org/883781
Closes: https://bugs.gentoo.org/883781