Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-apps/gitea: add 1.19.3 #31136

Closed
wants to merge 1 commit into from
Closed

Conversation

eeyrjmr
Copy link
Contributor

@eeyrjmr eeyrjmr commented May 22, 2023

Signed-off-by: JonRB <jon.roadleybattin@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @eeyrjmr
Areas affected: ebuilds
Packages affected: www-apps/gitea

www-apps/gitea: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 22, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-22 20:08 UTC
Newest commit scanned: 9d7b246
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c55a6b82fa/output.html

Comment on lines +46 to +52
-e "s#^ROOT =#ROOT = ${EPREFIX}/var/lib/gitea/gitea-repositories#"
-e "s#^ROOT_PATH =#ROOT_PATH = ${EPREFIX}/var/log/gitea#"
-e "s#^APP_DATA_PATH = data#APP_DATA_PATH = ${EPREFIX}/var/lib/gitea/data#"
-e "s#^HTTP_ADDR = 0.0.0.0#HTTP_ADDR = 127.0.0.1#"
-e "s#^MODE = console#MODE = file#"
-e "s#^DISABLE_ROUTER_LOG = false#DISABLE_ROUTER_LOG = true#"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we start clearing these up?

 * SED: some expressions in the following did not cause any changes
 *     sed -i "${sedcmds[@]}" custom/conf/app.example.ini || die;
 * no-op: -e s#^ROOT =#ROOT = /var/lib/gitea/gitea-repositories#
 * no-op: -e s#^ROOT_PATH =#ROOT_PATH = /var/log/gitea#
 * no-op: -e s#^APP_DATA_PATH = data#APP_DATA_PATH = /var/lib/gitea/data#
 * no-op: -e s#^HTTP_ADDR = 0.0.0.0#HTTP_ADDR = 127.0.0.1#
 * no-op: -e s#^DISABLE_ROUTER_LOG = false#DISABLE_ROUTER_LOG = true#

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thats odd... when you raised this with 1.19.1 I went through the list and two could be removed and this is incorporated here. The others are still needed IF these changes from upstream default are still wanted

#30340 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, EPREFIX is still something we want. Gonna fix later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants