-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-apps/the_silver_searcher: define _LARGEFILE64_SOURCE for non glib… #31186
base: master
Are you sure you want to change the base?
Conversation
Pull Request assignmentSubmitter: @listout sys-apps/the_silver_searcher: @wraeth Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-05-27 14:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This isn't right, see https://bugs.gentoo.org/903611#c0. |
Is typedef-ing off_t off64_t alright? |
Pull request CI reportReport generated at: 2023-05-28 06:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Using data types from _LARGEFILE64_SOURCE is discouraged as it will be removed in later versions of musl. Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Pull request CI reportReport generated at: 2023-05-28 06:33 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
First discovered in while building on musl [1]. This is because musl-1.2.4 (9999 right now) will remove/removes the LFS compatibility hacks, like fopen64: - https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4 - https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b659170e7b9c7db9bc The gist is that bad configure tests (suffering from -Wimplicit-function-declaration) would build and link successfully because musl provided these symbols as aliases, despite not needing them (musl natively supports both LFS & time64). To head this off, these aliases are now gone, but remain in libc.so for binary compatibility. The proper fix is to just use the regular functions and not anything _LARGEFILE64_SOURCE As a temporary workaround you can typedef off_t to off64_t [2] to get it working. [1]: https://bugs.gentoo.org/908582 [2]: gentoo/gentoo#31186 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
It's tolerable but I'd prefer it if we didn't. See https://bugs.gentoo.org/903611#c0, but I could've maybe been more verbose (I'll write something up on the wiki later):
|
…c systems