Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump frescobaldi to 2.18.1 and depend on python-ly, fixes #543052, #561022 #312

Closed
wants to merge 3 commits into from
Closed

Bump frescobaldi to 2.18.1 and depend on python-ly, fixes #543052, #561022 #312

wants to merge 3 commits into from

Conversation

karllinden
Copy link
Contributor

Also the 2.18 version has been removed.

@filmor
Copy link

filmor commented Oct 31, 2015

Any particular reason for removing Python 3 from the compat list? I'm running Frescobaldi fine with 3.4 with the ebuild from Bugzilla.

@karllinden
Copy link
Contributor Author

I could not figure out what would happen if it was built with portmidi and python3 and I wanted to be sure it works with all python implementations. Also one would have to use python_gen_cond_dep to make repoman happy. (Honestly, I did not research any deeper what would happen when USE="portmidi" and PYTHON_TARGETS="python3_*".)

@idella
Copy link

idella commented Nov 5, 2015

eeeer
@gentoo/proxy-maint

@idella
Copy link

idella commented Nov 5, 2015

@LilRC ; starting with the new dev-python/python-ly

  1. while the python impls work in those in PYTHON_COMPAT, you're expected to have run tested on all. You have pypy3 emerged?
  2. KEYWORDS are clearly copy pasted from another ebuild. For a new package, similarly one submits only on the arches on which you tested. For amd64, you can default add x86.
  3. The doc build connects to the internet which is disallowed in 'gentoo protocol". A full emerge need occur with no connection to a network.
    See: WARNING: autodoc: failed to import module u'ly.data.makeschemedata'; the following exception was raised:
    For this we might have to sacrifice a doc build.
  4. The install need be set to doc?build for installing the built docs.
    python-ly has to be made 'right' before moving onto Bump frescobaldi.

@mgorny
Copy link
Member

mgorny commented Nov 5, 2015

@gentoochainsaw, @aballier, @chutz, @radhermit, @yngwin, @gentoo/python for frescobaldi

@mgorny mgorny added the assigned PR successfully assigned to the package maintainer(s). label Nov 5, 2015
@karllinden
Copy link
Contributor Author

@idella @mgorny: I will and want to fix the issues when I find some time.

@karllinden
Copy link
Contributor Author

@idella
1 & 2. OK. I got the ebuild from @filmor, but I guess he also copy pasted it. Dropped.
3 & 4. Would it be unnacceptibly lazy to drop the doc USE-flag, entirely?

@mgorny
Copy link
Member

mgorny commented Nov 8, 2015

It's fine unless it's really needed to use this ;-).

@karllinden
Copy link
Contributor Author

I can use frescobaldi without the documentation for pythons-ly, so I dropped the USE-flag. :)

@filmor
Copy link

filmor commented Nov 8, 2015

Regarding 1 and 2, I have indeed only tested x86 and amd64 with cpython 2.7, 3.3 and 3.4. I just assumed since the library is pure python, but I see your point.

@idella
Copy link

idella commented Nov 9, 2015

pypy and pypy3 are fine once emerged, just like Cpython, but they are poorly understood and very thinly and poorly supported in 'userland'. You can do without them.

Docs are nice if they work, but if they're troublesome, abandon them without guilt.
So this pull request is a double barrelled. Ideally it ought be one package per request, but not to worry. Is python-ly looking 'good to go'?

@karllinden
Copy link
Contributor Author

@idella: I do not think it is worthwhile to include USE="doc" for python-ly, no. You are not asking if I think python-ly looks good to go, right? Anyway, I will rebase the python-ly commits when I get home today so that it is merge ready.

Package-Manager: portage-2.2.23
…wrt #543052, #561022

Package-Manager: portage-2.2.23
Package-Manager: portage-2.2.23
@karllinden
Copy link
Contributor Author

Rebased. I am ready to go on.

@idella
Copy link

idella commented Nov 11, 2015

python-ly has a doc build but we can do that later. Missed preserving the sig this time otherwise merged.

@mgorny mgorny closed this Nov 11, 2015
@karllinden karllinden deleted the bugs-543052-561022 branch November 12, 2015 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
5 participants