dev-python/notebook: Version bump to 4.3.0 #3130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-repo-qa-bot
added
the
assigned
|
Pull Request assignment Areas affected: ebuilds dev-python/notebook: @gentoo/sci |
SoapGentoo
suggested changes
Dec 19, 2016
| python_install() { | ||
| distutils-r1_python_install | ||
|
|
||
| ln -sf \ |
There was a problem hiding this comment.
have you tried using dosym here instead? More Gentoo-ish
There was a problem hiding this comment.
Replacing ln -sf with doysm results in
* ERROR: dev-python/notebook-4.3.0::gentoo failed:
* Aborting due to QA concerns: 15 files installed in /var/tmp/portage/dev-python/notebook-4.3.0/image/var/tmp/portage/dev-python/notebook-4.3.0/image/
There was a problem hiding this comment.
@SoapGentoo So, do we leave it as is or do we have to change this?
|
|
||
| pkg_preinst() { | ||
| # remove old mathjax folder if present | ||
| rm -rf "${EROOT}"/usr/lib*/python*/site-packages/notebook/static/components/MathJax || die |
There was a problem hiding this comment.
double-slashed, make this "${EROOT%/}"
Package-Manager: portage-2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SoapGentoo Simple copy of the previous ebuild. Tests pass for python 2.7 and 3.4, with commit 733fbcd reverted, with breaks my test system (see bug 524322).