www-client/chromium: add 114.0.5735.110 #31344

Kangie · 2023-06-08T00:24:05Z

I had a go at bumping this ebuild after the recent update in -dev.

Good news: I can prepare and compile the source (with GCC 13!) and the installed binary works.

Bad news: I didn't ccache and forgot to run tests so that's going to be another 6+ hours away.

Add myself as a maintainer; I'll be a backup - @jeffgazso has more desire to maintain this package ongoing but I got to this bump first.

@thesamesam @floppym: Do you have any feedback at this stage? In particular, are there any distros whose packaging would be worth eyeballing to catch any required patches / regressions?

I'm not super happy with rming ~4/5 of the gcc13 patches; it might be better to just specify the 5 that we want to run or cut a new patch tarball. I strongly dislike the concept of storing patches on a random git repository that I control so if we want to go with the latter approach I might get one of you stash one in a dev space.

For posterity these are the only required patches for 114:

chromium-112-gcc-13-0001-openscreen.patch
chromium-112-gcc-13-0003-ruy.patch
chromium-112-gcc-13-0005-tensorflow-tflite.patch
chromium-112-gcc-13-0006-vulkanmemoryallocator.patch
chromium-112-gcc-13-0014-maldoca.patch

Also, is the following still valid? I'm on Nvidia GPU and Wayland and everything seems fine for now.

Proprietary nVidia driver does not work with Wayland. You can disable

Wayland by setting DISABLE_OZONE_PLATFORM=true in /etc/chromium/default.

gentoo-repo-qa-bot · 2023-06-08T00:34:05Z

Pull request CI report

Report generated at: 2023-06-08 00:34 UTC
Newest commit scanned: 0d8b10f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a6e5331f80/output.html

floppym · 2023-06-08T16:08:06Z

Thanks for the PR!

Add myself as a maintainer; I'll be a backup - @jeffgazso has more desire to maintain this package ongoing but I got to this bump first.

~~Please drop proxy-maint from the maintainers. I think it would be best if someone familiar with the ebuild reviews PRs for now.~~

@thesamesam @floppym: Do you have any feedback at this stage? In particular, are there any distros whose packaging would be worth eyeballing to catch any required patches / regressions?

I'm not sure, but I would imagine that Debian, Ubuntu, and Arch would be good candidates for reference.

I'm not super happy with rming ~4/5 of the gcc13 patches; it might be better to just specify the 5 that we want to run or cut a new patch tarball. I strongly dislike the concept of storing patches on a random git repository that I control so if we want to go with the latter approach I might get one of you stash one in a dev space.

Yeah, I was feeling lazy and didn't roll a new tarball when adding 113. The patches in sam's tarball should become fully obsolete within a few major versions, so it isn't a permanent issue.

Also, is the following still valid? I'm on Nvidia GPU and Wayland and everything seems fine for now.

Proprietary nVidia driver does not work with Wayland. You can disable

Wayland by setting DISABLE_OZONE_PLATFORM=true in /etc/chromium/default.

Please feel free to drop the warning if you think it no longer applies. We can always restore it later if necessary.

thesamesam · 2023-06-08T21:59:41Z

@thesamesam @floppym: Do you have any feedback at this stage? In particular, are there any distros whose packaging would be worth eyeballing to catch any required patches / regressions?

I'm not sure, but I would imagine that Debian, Ubuntu, and Arch would be good candidates for reference.

Alpine as well.

I'm not super happy with rming ~4/5 of the gcc13 patches; it might be better to just specify the 5 that we want to run or cut a new patch tarball. I strongly dislike the concept of storing patches on a random git repository that I control so if we want to go with the latter approach I might get one of you stash one in a dev space.

Yeah, I was feeling lazy and didn't roll a new tarball when adding 113. The patches in sam's tarball should become fully obsolete within a few major versions, so it isn't a permanent issue.

We should probably import sultan's chromium-patches repo into somewhere on infra and just use that going forward. But the hack here is fine for this one time, I'd say. Maybe even until 115 when all of the patches should have landed.

thesamesam · 2023-06-08T22:40:55Z

Also, could you check if the patches in https://bugs.gentoo.org/906911 and https://bugs.gentoo.org/906962 are in this version? It'd be a shame to have to revbump again for them if they're not.

juippis · 2023-06-09T10:22:33Z

Looks like you're missing rust BDEP dependency,

ERROR at //build/config/rust.gni:143:22: Script returned non-zero exit code.
    rustc_revision = exec_script("//tools/rust/update_rust.py",
                     ^----------
Current dir: /var/tmp/portage/www-client/chromium-114.0.5735.110/work/chromium-114.0.5735.110/out/Release/
Command: python3.11 /var/tmp/portage/www-client/chromium-114.0.5735.110/work/chromium-114.0.5735.110/tools/rust/update_rust.py --     print-package-version
Returned 1 and printed out:
 
The expected Rust version is 17c11672167827b0dd92c88ef69f24346d1286dd-1-llvmorg-17-init-8029-g27f27d15-3 (or fallback                 17c11672167827b0dd92c88ef69f24346d1286dd-1-llvmorg-17-init-8029-g27f27d15-1 but the actual version is None
Did you run "gclient sync"?

See //BUILD.gn:17:1: whence it was imported.
import("//build/config/rust.gni")
^-------------------------------
 * ERROR: www-client/chromium-114.0.5735.110::gentoo failed (configure phase):
 *   (no error message)

With rust-bin-1.69.0 installed I chromium builds fine with default use flags:
>>> Completed (1 of 1) www-client/chromium-114.0.5735.110::gentoo

I think this is +lto or +libcxx related, I get:

ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'.  Try: '/usr/lib/llvm/16/bin/ld.lld --help'
ld.lld: Did you mean '--disable-auto-paired-vec-st'?
x86_64-pc-linux-gnu-clang++: error: linker command failed with exit code 1 (use -v to see invocation)

With

USE: X abi_x86_64 amd64 elibc_glibc gtk4 kernel_linux l10n_fi l10n_sv libcxx lto official pax-kernel pic pulseaudio suid system-harfbuzz system-png

I will keep testing in the background but it takes like 2 hours to compile this

gentoo-repo-qa-bot · 2023-06-09T10:34:11Z

Pull request CI report

Report generated at: 2023-06-09 10:34 UTC
Newest commit scanned: 1b1130a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/74c4a8b3b4/output.html

gentoo-repo-qa-bot · 2023-06-09T10:44:35Z

Pull request CI report

Report generated at: 2023-06-09 10:44 UTC
Newest commit scanned: d8833da
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3e02b24034/output.html

gentoo-repo-qa-bot · 2023-06-09T10:54:15Z

Pull request CI report

Report generated at: 2023-06-09 10:54 UTC
Newest commit scanned: 432b5b9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ba3731c0be/output.html

Kangie · 2023-06-09T11:01:21Z

I will keep testing in the background but it takes like 2 hours to compile this

hahaha. 5 hours here.

Good catch on the rust bdep; fixed.

Bad news, I'd heard about this but thought it was a later release - chromium now requires an unreleased llvm to build. We've reverted the patch for now, but longer term it's probably better to just build a separate llvm for chromium to prevent "fun" like this again.

gentoo-repo-qa-bot · 2023-06-09T11:14:15Z

Pull request CI report

Report generated at: 2023-06-09 11:14 UTC
Newest commit scanned: 08d697e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4ad7eebd00/output.html

gentoo-bot · 2023-06-09T11:32:06Z

Pull Request assignment

Submitter: @Kangie
Areas affected: ebuilds
Packages affected: www-client/chromium

www-client/chromium: @gentoo/chromium

Linked bugs

Bugs linked: 907999, 906962, 906911

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2023-06-09T11:39:26Z

Pull request CI report

Report generated at: 2023-06-09 11:39 UTC
Newest commit scanned: 36c237c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8d9ce3e4f8/output.html

stha09 · 2023-06-09T12:25:06Z

Looks like you're missing rust BDEP dependency,

ERROR at //build/config/rust.gni:143:22: Script returned non-zero exit code.
    rustc_revision = exec_script("//tools/rust/update_rust.py",
                     ^----------
Current dir: /var/tmp/portage/www-client/chromium-114.0.5735.110/work/chromium-114.0.5735.110/out/Release/
Command: python3.11 /var/tmp/portage/www-client/chromium-114.0.5735.110/work/chromium-114.0.5735.110/tools/rust/update_rust.py --     print-package-version
Returned 1 and printed out:
 
The expected Rust version is 17c11672167827b0dd92c88ef69f24346d1286dd-1-llvmorg-17-init-8029-g27f27d15-3 (or fallback                 17c11672167827b0dd92c88ef69f24346d1286dd-1-llvmorg-17-init-8029-g27f27d15-1 but the actual version is None
Did you run "gclient sync"?

See //BUILD.gn:17:1: whence it was imported.
import("//build/config/rust.gni")
^-------------------------------
 * ERROR: www-client/chromium-114.0.5735.110::gentoo failed (configure phase):
 *   (no error message)

With rust-bin-1.69.0 installed I chromium builds fine with default use flags: >>> Completed (1 of 1) www-client/chromium-114.0.5735.110::gentoo

I think this is +lto or +libcxx related, I get:

ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'.  Try: '/usr/lib/llvm/16/bin/ld.lld --help'
ld.lld: Did you mean '--disable-auto-paired-vec-st'?
x86_64-pc-linux-gnu-clang++: error: linker command failed with exit code 1 (use -v to see invocation)

With

USE: X abi_x86_64 amd64 elibc_glibc gtk4 kernel_linux l10n_fi l10n_sv libcxx lto official pax-kernel pic pulseaudio suid system-harfbuzz system-png

I will keep testing in the background but it takes like 2 hours to compile this

Just pass --enable_rust=false for the moment. Rust is only used for testing.

stha09 · 2023-06-09T12:28:46Z

disable-auto-upgrade-debug-info

You need to update the compiler patch and drop this one:
https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/build/config/compiler/BUILD.gn#768

Compiling in less an hour here ;)

www-client/chromium/chromium-114.0.5735.110.ebuild

Kangie · 2023-06-09T12:56:48Z

disable-auto-upgrade-debug-info

You need to update the compiler patch and drop this one: https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/build/config/compiler/BUILD.gn#768

I think I covered that in the llvm patch

Just pass --enable_rust=false for the moment. Rust is only used for testing.

that's a myconf_gn ebuild option?

thesamesam · 2023-06-09T13:00:36Z

disable-auto-upgrade-debug-info

You need to update the compiler patch and drop this one: chromium.googlesource.com/chromium/src.git/+/refs/heads/main/build/config/compiler/BUILD.gn#768

I think I covered that in the llvm patch

I think the idea here is you can fold it into something existing and it's slightly smaller then - we can just make the condition always true rather than just for chromeos.

gentoo-repo-qa-bot · 2023-06-09T13:09:16Z

Pull request CI report

Report generated at: 2023-06-09 13:09 UTC
Newest commit scanned: 0952af4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/45b8ae207c/output.html

Add myself as a maintainer Closes: https://bugs.gentoo.org/906911 Closes: https://bugs.gentoo.org/906962 Bug: https://bugs.gentoo.org/907999 Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>

gentoo-repo-qa-bot · 2023-06-09T13:49:07Z

Pull request CI report

Report generated at: 2023-06-09 13:49 UTC
Newest commit scanned: 0676b4d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7d77ba4e30/output.html

PF4Public · 2023-06-09T18:29:19Z

.110 is Windows release, Linux is currently at .106. Just sayin'

thesamesam · 2023-06-10T05:08:47Z

.110 is Windows release, Linux is currently at .106. Just sayin'

I'm not too worried about this bit as historically (I think, correct me if I'm wrong) the tarballs haven't existed if it's really a Windows-only release, I think?

PF4Public · 2023-06-10T11:26:28Z

the tarballs haven't existed if it's really a Windows-only release, I think?

AFAIK they stopped generating tarballs for everything except Linux at some point, but this change was reverted soon enough. So presently all tarballs are supposed to be generated.

thesamesam · 2023-06-10T11:27:34Z

Ah! Thank you, I'll keep an eye out for this going forward then

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 8, 2023

Kangie force-pushed the bump_chromium branch from 0d8b10f to 1b1130a Compare June 9, 2023 10:22

Kangie force-pushed the bump_chromium branch from 1b1130a to d8833da Compare June 9, 2023 10:28

Kangie force-pushed the bump_chromium branch from d8833da to 432b5b9 Compare June 9, 2023 10:38

Kangie force-pushed the bump_chromium branch from 432b5b9 to 08d697e Compare June 9, 2023 11:00

Kangie changed the title ~~www-client/chromium: add 114.0.5735.110~~ www-client/chromium: add 114.0.5735.110 [please reassign] Jun 9, 2023

gentoo-bot changed the title ~~www-client/chromium: add 114.0.5735.110 [please reassign]~~ www-client/chromium: add 114.0.5735.110 Jun 9, 2023

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 9, 2023

Kangie force-pushed the bump_chromium branch from 08d697e to 36c237c Compare June 9, 2023 11:28

Kangie changed the title ~~www-client/chromium: add 114.0.5735.110~~ www-client/chromium: add 114.0.5735.110 [please reassign] Jun 9, 2023

gentoo-bot changed the title ~~www-client/chromium: add 114.0.5735.110 [please reassign]~~ www-client/chromium: add 114.0.5735.110 Jun 9, 2023

gentoo-bot added the security PR that needs to be merged promptly as it addresses security issues label Jun 9, 2023

stha09 reviewed Jun 9, 2023

View reviewed changes

www-client/chromium/chromium-114.0.5735.110.ebuild Outdated Show resolved Hide resolved

Kangie force-pushed the bump_chromium branch from 36c237c to 0952af4 Compare June 9, 2023 12:55

www-client/chromium: add 114.0.5735.110

0676b4d

Add myself as a maintainer Closes: https://bugs.gentoo.org/906911 Closes: https://bugs.gentoo.org/906962 Bug: https://bugs.gentoo.org/907999 Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>

Kangie force-pushed the bump_chromium branch from 0952af4 to 0676b4d Compare June 9, 2023 13:36

floppym approved these changes Jun 9, 2023

View reviewed changes

gentoo-bot closed this in f747a37 Jun 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

www-client/chromium: add 114.0.5735.110 #31344

www-client/chromium: add 114.0.5735.110 #31344

Kangie commented Jun 8, 2023 •

edited

gentoo-repo-qa-bot commented Jun 8, 2023

floppym commented Jun 8, 2023 •

edited

thesamesam commented Jun 8, 2023 •

edited

thesamesam commented Jun 8, 2023

juippis commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

Kangie commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

gentoo-bot commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

stha09 commented Jun 9, 2023 •

edited

stha09 commented Jun 9, 2023

Kangie commented Jun 9, 2023 •

edited

thesamesam commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

PF4Public commented Jun 9, 2023

thesamesam commented Jun 10, 2023

PF4Public commented Jun 10, 2023

thesamesam commented Jun 10, 2023

www-client/chromium: add 114.0.5735.110 #31344

www-client/chromium: add 114.0.5735.110 #31344

Conversation

Kangie commented Jun 8, 2023 • edited

gentoo-repo-qa-bot commented Jun 8, 2023

Pull request CI report

floppym commented Jun 8, 2023 • edited

thesamesam commented Jun 8, 2023 • edited

thesamesam commented Jun 8, 2023

juippis commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

Kangie commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

gentoo-bot commented Jun 9, 2023

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

stha09 commented Jun 9, 2023 • edited

stha09 commented Jun 9, 2023

Kangie commented Jun 9, 2023 • edited

thesamesam commented Jun 9, 2023

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

gentoo-repo-qa-bot commented Jun 9, 2023

Pull request CI report

PF4Public commented Jun 9, 2023

thesamesam commented Jun 10, 2023

PF4Public commented Jun 10, 2023

thesamesam commented Jun 10, 2023

Kangie commented Jun 8, 2023 •

edited

floppym commented Jun 8, 2023 •

edited

thesamesam commented Jun 8, 2023 •

edited

stha09 commented Jun 9, 2023 •

edited

Kangie commented Jun 9, 2023 •

edited