Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/musescore: add missing dependencies #31421

Closed
wants to merge 1 commit into from

Conversation

NexAdn
Copy link
Contributor

@NexAdn NexAdn commented Jun 13, 2023

The dependency on GTest seems to be only at build time, probably due to a few macros to make the code easier to test. The software is not linked against GTest, so it can be safely removed after installation.

Closes: https://bugs.gentoo.org/907955
Closes: https://bugs.gentoo.org/907945

The dependency on GTest seems to be only at build time, probably due to
a few macros to make the code easier to test. The software is not linked
against GTest, so it can be safely removed after installation.

Closes: https://bugs.gentoo.org/907955
Closes: https://bugs.gentoo.org/907945
Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @NexAdn
Areas affected: ebuilds
Packages affected: media-sound/musescore

media-sound/musescore: @gentoo/sound

Linked bugs

Bugs linked: 907945, 907955


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 13, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-13 16:45 UTC
Newest commit scanned: 1dfadfd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2c3eb81b11/output.html

@fordfrog
Copy link
Contributor

thank you for handling it. i just changed your patch so that we don't introduce a revbump as both issues are only compilation issues so we there is no reason to force those users that already compiled the package successfully to emerge a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants