net-nds/ldapvi: Fix call to undeclared function on_exit #31513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request assignmentSubmitter: @listout net-nds/ldapvi: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 898066 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2023-06-17 16:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
juippis
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Hmm! Can't compile this with clang-16. gcc-13 works fine.
>>> Compiling source in /var/tmp/portage/net-nds/ldapvi-1.7_p20101214-r5/work/ldapvi-1.7_p20101214/ldapvi ...
make -j32
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o ldapvi.o ldapvi.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o data.o data.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o diff.o diff.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o error.o error.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o misc.o misc.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o parse.o parse.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o port.o port.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o print.o print.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o search.o search.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o base64.o base64.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o arguments.o arguments.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o parseldif.o parseldif.c
clang -c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=native -O2 -pipe -frecord-gcc-switches -o sasl.o sasl.c
arguments.c:191:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute
[-Wunused-result]
write(fd, USAGE, strlen(USAGE));
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
arguments.c:567:4: warning: add explicit braces to avoid dangling else [-Wdangling-else]
else if (strcmp(value, "yes")) {
^
sasl.c:79:2: warning: SASL support disabled [-W#warnings]
#warning SASL support disabled
^
parse.c:39:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit function
declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
parse.c:64:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit functionparseldif.c:43:16:
error: 1 declarations warning [-Wimplicit-function-declaration] generated.
call
to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
switch ( c = getc_unlocked(s)) {
^
parse.c:89:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit function
parseldif.c:80:declarations16: [-Wimplicit-function-declaration]error: call
to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
switch ( c = getc_unlocked(s)) {
^
parseldif.c:113:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
parseldif.c:214:9: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
if ( c = ldif_read_ad(s, name)) return c;
~~^~~~~~~~~~~~~~~~~~~~~~~
parseldif.c:214:9: note: place parentheses around the assignment to silence this warning
if ( c = ldif_read_ad(s, name)) return c;
^
( )
parseldif.c:214:9: note: use '==' to turn this assignment into an equality comparison
if ( c = ldif_read_ad(s, name)) return c;
^
==
parse.c:224:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
if ( encoding = memchr(name->str, ':', name->len)) {
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
parse.c:224:16: note: place parentheses around the assignment to silence this warning
if ( encoding = memchr(name->str, ':', name->len)) {
^
( )
parse.c:224:16: note: use '==' to turn this assignment into an equality comparison
if ( encoding = memchr(name->str, ':', name->len)) {
^
==
1 warning and 3 errors generated.
1 warning and 3 errors generated.
make: *** [GNUmakefile:16: parse.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [GNUmakefile:16: parseldif.o] Error 1
ldapvi.c:579:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute
[-Wunused-result]
mkdtemp(dir);
^~~~~~~ ~~~
ldapvi.c:721:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
if ( rc = ldap_initialize(&ld, server)) {
~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ldapvi.c:721:10: note: place parentheses around the assignment to silence this warning
if ( rc = ldap_initialize(&ld, server)) {
^
( )
ldapvi.c:721:10: note: use '==' to turn this assignment into an equality comparison
if ( rc = ldap_initialize(&ld, server)) {
^
==
ldapvi.c:766:2: warning: Deprecated pre-processor symbol: replace with "g_string_append_printf" [-W#pragma-messages]
g_string_sprintfa(name, "-%d.ldif", getpid());
^
/usr/include/glib-2.0/glib/gstring.h:290:51: note: expanded from macro 'g_string_sprintfa'
#define g_string_sprintfa g_string_append_printf GLIB_DEPRECATED_MACRO_IN_2_26_FOR(g_string_append_printf)
^
/usr/include/glib-2.0/glib/glib-visibility.h:40:46: note: expanded from macro 'GLIB_DEPRECATED_MACRO_IN_2_26_FOR'
#define GLIB_DEPRECATED_MACRO_IN_2_26_FOR(f) GLIB_DEPRECATED_MACRO_FOR (f)
^
/usr/include/glib-2.0/glib/gmacros.h:1299:3: note: expanded from macro 'GLIB_DEPRECATED_MACRO_FOR'
_GLIB_GNUC_DO_PRAGMA(GCC warning G_STRINGIFY (Deprecated pre-processor symbol: replace with #f))
^
/usr/include/glib-2.0/glib/gmacros.h:1296:33: note: expanded from macro '_GLIB_GNUC_DO_PRAGMA'
#define _GLIB_GNUC_DO_PRAGMA(x) _Pragma(G_STRINGIFY (x))
^
<scratch space>:66:6: note: expanded from here
GCC warning "Deprecated pre-processor symbol: replace with \"g_string_append_printf\""
^
misc.c:403:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
write(2, "\nmalloc error\n", sizeof("\nmalloc error\n") - 1);
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
misc.c:417:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
write(2, "\nstrdup error\n", sizeof("\nstrdup error\n") - 1);
^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
port.c:134:20: warning: passing 'char[4]' to parameter ofldapvi.c: 1221type: 3: warning: 'unsigned char *'add explicit bracesconverts tobetween avoid dangling pointerselse to integer
types[-Wdangling-else]
where else
^
one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
RAND_pseudo_bytes(rand, sizeof(rand));
^~~~
/usr/include/openssl/rand.h:61:31: note: passing argument to parameter 'buf' here
int RAND_bytes(unsigned char *buf, int num);
^
port.c:136:2: warning: 'SHA1_Init' is deprecated [-Wdeprecated-declarations]
SHA1_Init(&SHA1context);
^
/usr/include/openssl/sha.h:49:1: note: 'SHA1_Init' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:137:2: warning: 'SHA1_Update' is deprecated [-Wdeprecated-declarations]
SHA1_Update(&SHA1context, key, strlen(key));
^
/usr/include/openssl/sha.h:50:1: note: 'SHA1_Update' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:138:2: warning: 'SHA1_Update' is deprecated [-Wdeprecated-declarations]
SHA1_Update(&SHA1context, rand, sizeof(rand));
^
/usr/include/openssl/sha.h:50:1: note: 'SHA1_Update' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:139:2: warning: 'SHA1_Final' is deprecated [-Wdeprecated-declarations]
SHA1_Final(tmp, &SHA1context);
^
/usr/include/openssl/sha.h:51:1: note: 'SHA1_Final' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:154:2: warning: 'MD5' is deprecated [-Wdeprecated-declarations]
MD5((unsigned char *) key, strlen(key), tmp);
^
/usr/include/openssl/md5.h:52:1: note: 'MD5' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 unsigned char *MD5(const unsigned char *d, size_t n,
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:168:2: warning: 'MD5_Init' is deprecated [-Wdeprecated-declarations]
MD5_Init(&MD5context);
^
/usr/include/openssl/md5.h:49:1: note: 'MD5_Init' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int MD5_Init(MD5_CTX *c);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:169:2: warning: 'MD5_Update' is deprecated [-Wdeprecated-declarations]
MD5_Update(&MD5context, key, strlen(key));
^
/usr/include/openssl/md5.h:50:1: note: 'MD5_Update' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int MD5_Update(MD5_CTX *c, const void *data, size_t len);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:170:2: warning: 'MD5_Update' is deprecated [-Wdeprecated-declarations]
MD5_Update(&MD5context, rand, sizeof(rand));
^
/usr/include/openssl/md5.h:50:1: note: 'MD5_Update' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int MD5_Update(MD5_CTX *c, const void *data, size_t len);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
port.c:171:2: warning: 'MD5_Final' is deprecated [-Wdeprecated-declarations]
MD5_Final(tmp, &MD5context);
^
/usr/include/openssl/md5.h:51:1: note: 'MD5_Final' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int MD5_Final(unsigned char *md, MD5_CTX *c);
^
/usr/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
# define OSSL_DEPRECATEDIN_3_0 OSSL_DEPRECATED(3.0)
^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
# define OSSL_DEPRECATED(since) __attribute__((deprecated))
^
10 warnings generated.
2 warnings generated.
2 warnings generated.
4 warnings generated.
* ERROR: net-nds/ldapvi-1.7_p20101214-r5::gentoo failed (compile phase):
This seems to be the culprit though:
error: 1 declarations warning [-Wimplicit-function-declaration] generated.
|
Lemme see |
|
@juippis how are you building (any specific use flags or something)? because I'm getting: http://ix.io/4AAj However I do an error in the install phase: But that might be unrelated |
|
You can see my cflags from the post above, nothing weird, only One weird thing I discovered is that this works on musl-clang:16, but not on normal system with clang:16. GCC-13 works fine with both. @thesamesam ideas about the error? |
|
Huh, that weird. I need setup a llvm-glibc testing environment as well |
|
@juippis can you add |
|
I'm trying something, I'll force push in a moment |
listout
force-pushed
the
ldapvi-musl-on_exit
branch
from
ccc33f1
to
700fe51
Compare
|
@juippis can you please try now |
listout
force-pushed
the
ldapvi-musl-on_exit
branch
from
700fe51
to
524721b
Compare
juippis
reviewed
Jul 15, 2023
There was a problem hiding this comment.
Still no, although the error with parse.c seems to be resolved, now I get a similar error with parseldif.c:
parseldif.c:43:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support
implicit function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
parseldif.c:80:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support
implicit function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
parseldif.c:113:16: error: call to undeclared function 'getc_unlocked'; ISO C99 and later do not support
implicit function declarations [-Wimplicit-function-declaration]
switch ( c = getc_unlocked(s)) {
^
parseldif.c:214:9: warning: using the result of an assignment as a condition without parentheses
[-Wparentheses]
if ( c = ldif_read_ad(s, name)) return c;
~~^~~~~~~~~~~~~~~~~~~~~~~
parseldif.c:214:9: note: place parentheses around the assignment to silence this warning
if ( c = ldif_read_ad(s, name)) return c;
^
( )
parseldif.c:214:9: note: use '==' to turn this assignment into an equality comparison
if ( c = ldif_read_ad(s, name)) return c;
^
==
1 warning and 3 errors generated.
make: *** [GNUmakefile:16: parseldif.o] Error 1
make: *** Waiting for unfinished jobs....
So progress I guess :)
Pull request CI reportReport generated at: 2023-07-15 07:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
ldapvi-musl-on_exit
branch
2 times, most recently
from
8631942
to
da3ea6d
Compare
|
I did add Build log: http://sprunge.us/qcZeVJ Very weird |
|
I may have gotten too eager, I do see the error again in parse.c and parseldif.c, just it was now way after. |
|
Okay, I'm out of ideas here. I'll wait for Sam to shed some light on this one. cc: @thesamesam |
Pull request CI reportReport generated at: 2023-07-15 08:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Let me take a look. |
|
Checking
glibc's default is not pure POSIX/ISO C, instead it sets So, let's see.. Uh oh! The source is setting I would also check in this case what musl guards the See also: |
|
@listout before I forget, could you take a look given the awesome information sam gave? |
|
Uhh ... yeah sure. But we continued this on IRC, I'll dig up the log. What's do you want me to take a look at. IIRC this something related to compiler-rt or something like that |
Closes: https://bugs.gentoo.org/898066 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
listout
force-pushed
the
ldapvi-musl-on_exit
branch
from
da3ea6d
to
bcff66c
Compare
Pull request CI reportReport generated at: 2023-09-30 17:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@juippis ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://bugs.gentoo.org/898066