Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles/base: change to PHP_TARGETS="php8-1" #31579

Merged
merged 1 commit into from Jun 23, 2023
Merged

profiles/base: change to PHP_TARGETS="php8-1" #31579

merged 1 commit into from Jun 23, 2023

Conversation

thesamesam
Copy link
Member

@thesamesam thesamesam commented Jun 22, 2023 •
edited

In preparation for OpenSSL 3.

Bug: https://bugs.gentoo.org/797676

@thesamesam thesamesam added the priority-ci Increase the priority for CI processing. Use scarcely. label Jun 22, 2023
@thesamesam
Copy link
Member Author

thesamesam commented Jun 22, 2023 •
edited

I'd prefer to just do straight to 8-1 because otherwise we've got a pretty limited window for users to be on openssl-3 before EOL, but let's see..

(The idea being I want time for people to be able to downgrade to openssl-1.1* if it breaks their workflow before it's EOL)

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: profiles
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 797676

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 22, 2023
@thesamesam thesamesam requested a review from orlitzky June 22, 2023 23:19
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-22 23:20 UTC
Newest commit scanned: 5d8aa54
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c7790308f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-22 23:35 UTC
Newest commit scanned: 0284203
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c2eeb70867/output.html

@thesamesam
Copy link
Member Author

OK, CI is happy.

@orlitzky unless you have an objection, I'd like to just merge it with straight 8-1.

@thesamesam thesamesam changed the title profiles/base: change to PHP_TARGETS="php8-0 php8-1" profiles/base: change to PHP_TARGETS="php8-1" Jun 22, 2023
@hydrapolic
Copy link
Contributor

Php 7.4 is eol, 8.0 is in security support only mode, it's about time to move to 8.1/8.2.

orlitzky
orlitzky approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@orlitzky orlitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections here. Thanks.

@thesamesam
Copy link
Member Author

Thanks both!

@thesamesam
profiles/base: change to PHP_TARGETS="php8-1"
cf60cdd 
Needed for OpenSSL 3. As noted in the PR, php7-4 is EOL and 8-0 is security-support
only, so let's zoom ahead to solely 8-1.

Bug: https://bugs.gentoo.org/797676
Closes: gentoo#31579
Signed-off-by: Sam James <sam@gentoo.org>
@gentoo-bot gentoo-bot merged commit cf60cdd into gentoo:master Jun 23, 2023
@thesamesam thesamesam deleted the php-ci branch June 23, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlitzky orlitzky orlitzky approved these changes

Assignees
No one assigned
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually. priority-ci Increase the priority for CI processing. Use scarcely.
Projects
None yet
Milestone
No milestone
5 participants
@thesamesam @gentoo-bot @gentoo-repo-qa-bot @hydrapolic @orlitzky