mate-base/mate-settings-daemon: Fix incompatible function pointer types #31624
Conversation
Pull Request assignmentSubmitter: @listout mate-base/mate-settings-daemon: @gentoo/mate Linked bugsBugs linked: 881315 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
Sending patch upstream |
| @@ -0,0 +1,14 @@ | |||
| Bug: https://bugs.gentoo.org/881315 | |||
There was a problem hiding this comment.
You've sent it upstream, I assume? If so, where's the link? If not, why not? 😉
Always upstream!
| atspi_init (); | ||
|
|
||
| - self->listener = atspi_device_listener_new (on_key_press_event, | ||
| + self->listener = atspi_device_listener_new ((AtspiDeviceListenerCB)on_key_press_event, |
There was a problem hiding this comment.
I'm not yet sure if this is actually right. I need to check.
There was a problem hiding this comment.
My initial patch was to remove const from on_key_press_event's paramer
static gboolean
-on_key_press_event (const AtspiDeviceEvent *event,
+on_key_press_event (AtspiDeviceEvent *event,
void *user_data G_GNUC_UNUSED)
{
/* don't ring on capslock itself, that's taken care of by togglekeysDo you think it's more appt. than the casting?
There was a problem hiding this comment.
Thanks for asking - I think the patch as it is (the cast) is better now I looked at it harder.
Pull request CI reportReport generated at: 2023-06-26 17:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
mate-settings-gettext0.22
branch
from
ad5d9c1
to
685bda5
Compare
Pull request CI reportReport generated at: 2023-06-26 18:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Maintainer disagrees with the patch and will probably fix it themselves |
|
Thanks. This is a good example of why:
|
|
I'll update the patch to match that of maintainers. |
|
Huh, in the upstream correct PR by dev, they are just removing the const parameter from the function, mate-desktop/mate-settings-daemon@42e91f2. |
|
Yeah, you can see they had to think for a while about whether it's the best way to go though and that it's a trade-off (and the API changed). |
The patch also fixes a memory leak, take from an open PR by mate dev. Closes: https://bugs.gentoo.org/881315 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
listout
force-pushed
the
mate-settings-gettext0.22
branch
from
685bda5
to
b0ab963
Compare
Pull request CI reportReport generated at: 2023-06-27 17:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
The patch also fixes a memory leak, take from an open PR by mate dev. Closes: https://bugs.gentoo.org/881315 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com> Closes: gentoo#31624 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Closes: https://bugs.gentoo.org/881315