app-editors/aee: Fix call to undeclared function wprintf #31670
Conversation
Closes: https://bugs.gentoo.org/894372 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Pull Request assignmentSubmitter: @listout app-editors/aee: @hattya Linked bugsBugs linked: 894372 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-06-29 18:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| */ | ||
|
|
||
| - buffer->journ_fd = NULL; | ||
| + buffer->journ_fd = 0; |
There was a problem hiding this comment.
Have you checked how a 0 journ_fd is handled?
There was a problem hiding this comment.
cc @x7upLime - iirc this is one of the packages you looked at too
There was a problem hiding this comment.
I remember journ_fd is not checked that much in aee..
(int) NULL and 0 for journal_fd should have similar effects I guess.. since is used only in calls to read/write/lseek.
journ_fd gets set to NULL during buffer initialization, or it gets voluntarily assigned to NULL instead of -1 if a call to open() fails; recover_from_journal() in journal.c does that.. Maybe having that function called could highlight any difference.. but I haven't tried.
There was a problem hiding this comment.
https://github.com/gentoo/gentoo/pull/30728/files Other patch uses -1
Closes: https://bugs.gentoo.org/894372