New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-admin/gtkdiskfree: Fix call to undeclared function setlocale #31671
Conversation
Closes: https://bugs.gentoo.org/894204 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Pull Request assignmentSubmitter: @listout app-admin/gtkdiskfree: Linked bugsBugs linked: 894204 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-06-29 19:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test this on musl due to https://bugs.gentoo.org/908071 :\
It requires musl-1.2.3-rx for librsvg to get librsvg |
Yeah but we should look into patching librsvg for musl-1.2.4 before fixing its deps. Or if that seems impossible, we can mask the broken version on musl profile. |
For now, please just test with musl-1.2.3 instead wrt librsvg/Rust issues if something fails to build. (Use musl-1.2.4 unless a dep fails.) |
I can indeed make a binpkg using musl-1.2.3 to not hit this issue every time, but I do feel like it should be fixed with profiles if possible. |
It's orthogonal to this and not worth worrying about here given the Rust situation is a massive headache. That's being handled separately. |
Oh yes, don't worry I wasn't asking @listout to handle the masking :) just talking out loud here, I'm willing to get involved if there is no plan in place! I'll process this PR tomorrow. |
Closes: https://bugs.gentoo.org/894204