Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-admin/gtkdiskfree: Fix call to undeclared function setlocale #31671

Closed
wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Jun 29, 2023

Closes: https://bugs.gentoo.org/894204
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: app-admin/gtkdiskfree

app-admin/gtkdiskfree: samuel.bauer[at]yahoo.fr, @gentoo/proxy-maint

Linked bugs

Bugs linked: 894204


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-29 19:25 UTC
Newest commit scanned: 00d8390
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5fcf4eb227/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this on musl due to https://bugs.gentoo.org/908071 :\

@listout
Copy link
Contributor Author

listout commented Jul 21, 2023

Can't test this on musl due to https://bugs.gentoo.org/908071 :\

It requires musl-1.2.3-rx for librsvg to get librsvg

@juippis
Copy link
Member

juippis commented Jul 21, 2023

Yeah but we should look into patching librsvg for musl-1.2.4 before fixing its deps. Or if that seems impossible, we can mask the broken version on musl profile.

@thesamesam
Copy link
Member

thesamesam commented Jul 22, 2023

For now, please just test with musl-1.2.3 instead wrt librsvg/Rust issues if something fails to build.

(Use musl-1.2.4 unless a dep fails.)

@juippis
Copy link
Member

juippis commented Jul 23, 2023

I can indeed make a binpkg using musl-1.2.3 to not hit this issue every time, but I do feel like it should be fixed with profiles if possible.

@thesamesam
Copy link
Member

It's orthogonal to this and not worth worrying about here given the Rust situation is a massive headache. That's being handled separately.

@juippis
Copy link
Member

juippis commented Jul 23, 2023

Oh yes, don't worry I wasn't asking @listout to handle the masking :) just talking out loud here, I'm willing to get involved if there is no plan in place!

I'll process this PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants