gnome-extra/gnome-weather: Version bump to 45_alpha #31751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request assignmentSubmitter: @flint2 gnome-extra/gnome-weather: @gentoo/gnome Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
-# Tests have a lot of issues, starting with reliance on a system installation,
-# accessing the network and other intermittent failures with network-sandbox disabled
-# https://gitlab.gnome.org/GNOME/gnome-weather/issues/67 (and rest not filed)
-# test dep: $(python_gen_any_dep 'dev-util/dogtail[${PYTHON_USEDEP}]')
-# With 3.34, this is now behind a dogtail option we can pass (and have data validation)
-This comment still seems relevant. Why remove it? |
I cannot reproduce the issues: |
|
That's because Apply this diff --git a/gnome-extra/gnome-weather/gnome-weather-45_alpha.ebuild b/gnome-extra/gnome-weather/gnome-weather-45_alpha.ebuild
index 38143d799022..efff46ee667e 100644
--- a/gnome-extra/gnome-weather/gnome-weather-45_alpha.ebuild
+++ b/gnome-extra/gnome-weather/gnome-weather-45_alpha.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit gnome.org gnome2-utils meson xdg
+inherit gnome.org gnome2-utils meson virtualx xdg
DESCRIPTION="A weather application for GNOME"
HOMEPAGE="https://wiki.gnome.org/Design/Apps/Weather"
@@ -33,7 +33,11 @@ BDEPEND="
"
src_configure() {
- meson_src_configure -Dprofile=default -Ddogtail=false
+ meson_src_configure -Dprofile=default -Ddogtail=true
+}
+
+src_test() {
+ virtx meson_src_test
}
pkg_postinst() {and you'll see the failure. |
Now I can reproduce it: Should we leave dogtail=true ? |
|
No :) The point was, you shouldn't remove the comment about why we have dogtail disabled. You said you didn't think it was relevant because you couldn't reproduce the issue. I showed you how to reproduce the issue... so the comment should remain and we should leave dogtail disabled. |
Signed-off-by: Guillermo Joandet <gjoandet@gmail.com>
Pull request CI reportReport generated at: 2023-07-12 23:50 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillermo Joandet gjoandet@gmail.com